summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Rajnoha <prajnoha@redhat.com>2014-10-23 10:18:29 +0200
committerPeter Rajnoha <prajnoha@redhat.com>2014-10-23 10:18:29 +0200
commit4b611bb816eef3e363e005b48b881e933c3de9e2 (patch)
tree4ed076347f9932d3c4f2086e29fe873fb9b66470
parent2c8e7821c31245e3f7c1d56a67eb7f38d4b37001 (diff)
downloadlvm2-4b611bb816eef3e363e005b48b881e933c3de9e2.tar.gz
report: lv_permissions: display read-only/read-only-override instead of blank when LV is not writeable
Before this patch: $ lvs -o name,lv_attr,lv_permissions LV Attr LPerms root -wi-ao---- writeable swap -wi-ao---- writeable lvol0 -Ri-a----- lvol1 -ri-a----- lvol2 -wi-a----- writeable lvol3 -ri------- With this patch applied: $ lvs -o name,lv_attr,lv_permissions LV Attr LPerms root -wi-ao---- writeable swap -wi-ao---- writeable lvol0 -Ri-a----- read-only-override lvol1 -ri-a----- read-only lvol2 -wi-a----- writeable lvol3 -ri------- read-only ("read-only-override" is displayed if the "writeable" permission is overriden based on "activation/read_only_volume_list" lvm.conf setting)
-rw-r--r--WHATS_NEW1
-rw-r--r--lib/report/values.h4
2 files changed, 3 insertions, 2 deletions
diff --git a/WHATS_NEW b/WHATS_NEW
index 0d4487e10..2d644c59c 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.02.112 -
=====================================
+ Fix lv_permissions reporting to display read-only{-override} instead of blank.
Fix liblvm2cmd and lvm shell to respect quotes around args in cmd line string.
Permit extent sizes > 128KB that are not power of 2 with lvm2 format.
Remove workaround for lvm2-monitor.service hang on stop if lvmetad stopped.
diff --git a/lib/report/values.h b/lib/report/values.h
index 7425bc632..fb368d459 100644
--- a/lib/report/values.h
+++ b/lib/report/values.h
@@ -77,8 +77,8 @@ FIELD_RESERVED_BINARY_VALUE(lv_device_open, lv_device_open, "", "open")
FIELD_RESERVED_BINARY_VALUE(lv_skip_activation, lv_skip_activation, "", "skip activation", "skip")
FIELD_RESERVED_BINARY_VALUE(zero, zero, "", "zero")
FIELD_RESERVED_VALUE(lv_permissions, lv_permissions_rw, "", FIRST_NAME(lv_permissions_rw), "writeable", "rw", "read-write")
-FIELD_RESERVED_VALUE(lv_permissions, lv_permissions_r, "", FIRST_NAME(lv_permissions_r), "", "read-only", "r", "ro")
-FIELD_RESERVED_VALUE(lv_permissions, lv_permissions_r_override, "", FIRST_NAME(lv_permissions_r_override), "", "read-only-override", "ro-override", "r-override", "R")
+FIELD_RESERVED_VALUE(lv_permissions, lv_permissions_r, "", FIRST_NAME(lv_permissions_r), "read-only", "r", "ro")
+FIELD_RESERVED_VALUE(lv_permissions, lv_permissions_r_override, "", FIRST_NAME(lv_permissions_r_override), "read-only-override", "ro-override", "r-override", "R")
FIELD_RESERVED_VALUE(lv_read_ahead, lv_read_ahead, "", RESERVED(number_undef_64), "auto")
/* *INDENT-ON* */