Move va_end(ap) so we do not leave with return -1 without calling it.

Remove unneeded ';'

1 files changed, 3 insertions, 2 deletions

diff --git a/libdm/libdm-string.c b/libdm/libdm-string.c
index d8fca1a90..365e7ec0d 100644
--- a/libdm/libdm-string.c
+++ b/libdm/libdm-string.c
@@ -144,6 +144,8 @@ int dm_asprintf(char **result, const char *format, ...)
 	while (!ok) {
 		va_start(ap, format);
 		n = vsnprintf(buf, size, format, ap);
+		va_end(ap);
+
 		if (0 <= n && n < size)
 			ok = 1;
 		else {
@@ -152,8 +154,7 @@ int dm_asprintf(char **result, const char *format, ...)
 			buf = dm_malloc(size);
 			if (!buf)
 				return -1;
-		};
-		va_end(ap);
+		}
 	}
 
 	*result = dm_strdup(buf);