diff options
| author | Alasdair G Kergon <agk@redhat.com> | 2016-02-26 15:46:37 +0000 |
|---|---|---|
| committer | Alasdair G Kergon <agk@redhat.com> | 2016-02-26 15:46:37 +0000 |
| commit | 98981265963f5c2572687cc7c8b49aa7cb6f85ec (patch) | |
| tree | 96bab25bf8d3a381efdc09ef389eeadb3056e7d7 /test | |
| parent | 183bd8ca0342f6f72630afcb42b453b88ee90ac6 (diff) | |
| download | lvm2-98981265963f5c2572687cc7c8b49aa7cb6f85ec.tar.gz | |
report: Shift (u)sed pv_attr under (a)llocatable.
Showing 'u' in the pv_attr reporting field is mostly unnecessary because
most PVs are allocatable, and being allocatable implies it is (u)sed,
and this is already obvious from other fields in the default 'pvs'
output like the VG name.
So move the new (u)sed pv_attr from character position 4 to 1, and only
show it in those rare cases when the PV is not (a)llocatable or the
relevant metadata is missing.
(Scripts should not be using pv_attr, but rather pv_allocatable,
pv_exported, pv_missing, pv_in_use etc.)
Diffstat (limited to 'test')
| -rw-r--r-- | test/shell/pvchange-usage.sh | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/shell/pvchange-usage.sh b/test/shell/pvchange-usage.sh index efffe18cc..df7893ee6 100644 --- a/test/shell/pvchange-usage.sh +++ b/test/shell/pvchange-usage.sh @@ -24,11 +24,11 @@ aux prepare_pvs 4 # check 'allocatable' pv attribute pvcreate "$dev1" -check pv_field "$dev1" pv_attr ---- +check pv_field "$dev1" pv_attr --- vgcreate $vg1 "$dev1" -check pv_field "$dev1" pv_attr a--u +check pv_field "$dev1" pv_attr a-- pvchange --allocatable n "$dev1" -check pv_field "$dev1" pv_attr ---u +check pv_field "$dev1" pv_attr u-- vgremove -ff $vg1 not pvchange --allocatable y "$dev1" pvremove -ff "$dev1" @@ -51,10 +51,10 @@ do # "vgchange disable/enable allocation for pvs with metadatacopies = $mda (bz452982)" pvchange "$dev1" -x n pvchange "$dev1" -x n # already disabled - check pv_field "$dev1" pv_attr ---u + check pv_field "$dev1" pv_attr u-- pvchange "$dev1" -x y pvchange "$dev1" -x y # already enabled - check pv_field "$dev1" pv_attr a--u + check pv_field "$dev1" pv_attr a-- # check we are able to change number of managed metadata areas if test $mda -gt 0 ; then |