diff options
Diffstat (limited to 'test/shell/lvconvert-raid.sh')
| -rw-r--r-- | test/shell/lvconvert-raid.sh | 62 |
1 files changed, 31 insertions, 31 deletions
diff --git a/test/shell/lvconvert-raid.sh b/test/shell/lvconvert-raid.sh index 6c05c67be..e74800371 100644 --- a/test/shell/lvconvert-raid.sh +++ b/test/shell/lvconvert-raid.sh @@ -23,7 +23,7 @@ get_image_pvs() { local images images=`dmsetup ls | grep ${1}-${2}_.image_.* | cut -f1 | sed -e s:-:/:` - lvs --noheadings -a -o devices $images | sed s/\(.\)// + lvs --noheadings -a -o devices "$images" | sed s/\(.\)// } ######################################################## @@ -227,14 +227,14 @@ done # - don't allow removal of primary while syncing # - DO allow removal of secondaries while syncing ########################################### -aux delay_dev $dev2 0 100 -lvcreate -aey -l 2 -n $lv1 $vg $dev1 +aux delay_dev "$dev2" 0 100 +lvcreate -aey -l 2 -n $lv1 $vg "$dev1" lvconvert -y -m 1 $vg/$lv1 \ - --config 'global { mirror_segtype_default = "raid1" }' $dev2 + --config 'global { mirror_segtype_default = "raid1" }' "$dev2" lvs --noheadings -o attr $vg/$lv1 | grep '^[[:space:]]*r' -not lvconvert --yes -m 0 $vg/$lv1 $dev1 -lvconvert --yes -m 0 $vg/$lv1 $dev2 -aux enable_dev $dev2 +not lvconvert --yes -m 0 $vg/$lv1 "$dev1" +lvconvert --yes -m 0 $vg/$lv1 "$dev2" +aux enable_dev "$dev2" lvremove -ff $vg ########################################### @@ -242,11 +242,11 @@ lvremove -ff $vg # - DO allow removal of primary while syncing # - DO allow removal of secondaries while syncing ########################################### -aux delay_dev $dev2 0 100 -lvcreate --type raid1 -m 2 -aey -l 2 -n $lv1 $vg $dev1 $dev2 $dev3 -lvconvert --yes -m 1 $vg/$lv1 $dev3 -lvconvert --yes -m 0 $vg/$lv1 $dev1 -aux enable_dev $dev2 +aux delay_dev "$dev2" 0 100 +lvcreate --type raid1 -m 2 -aey -l 2 -n $lv1 $vg "$dev1" "$dev2" "$dev3" +lvconvert --yes -m 1 $vg/$lv1 "$dev3" +lvconvert --yes -m 0 $vg/$lv1 "$dev1" +aux enable_dev "$dev2" lvremove -ff $vg ########################################### @@ -254,17 +254,17 @@ lvremove -ff $vg # - DO allow removal of one of primary sources # - Do not allow removal of all primary sources ########################################### -lvcreate --type raid1 -m 1 -aey -l 2 -n $lv1 $vg $dev1 $dev2 +lvcreate --type raid1 -m 1 -aey -l 2 -n $lv1 $vg "$dev1" "$dev2" aux wait_for_sync $vg $lv1 -aux delay_dev $dev3 0 100 -lvconvert --yes -m +1 $vg/$lv1 $dev3 +aux delay_dev "$dev3" 0 100 +lvconvert --yes -m +1 $vg/$lv1 "$dev3" # should allow 1st primary to be removed -lvconvert --yes -m -1 $vg/$lv1 $dev1 +lvconvert --yes -m -1 $vg/$lv1 "$dev1" # should NOT allow last primary to be removed -not lvconvert --yes -m -1 $vg/$lv1 $dev2 +not lvconvert --yes -m -1 $vg/$lv1 "$dev2" # should allow non-primary to be removed -lvconvert --yes -m 0 $vg/$lv1 $dev3 -aux enable_dev $dev3 +lvconvert --yes -m 0 $vg/$lv1 "$dev3" +aux enable_dev "$dev3" lvremove -ff $vg ########################################### @@ -272,15 +272,15 @@ lvremove -ff $vg # - Should allow removal of two devices, # as long as they aren't both primary ########################################### -lvcreate --type raid1 -m 1 -aey -l 2 -n $lv1 $vg $dev1 $dev2 +lvcreate --type raid1 -m 1 -aey -l 2 -n $lv1 $vg "$dev1" "$dev2" aux wait_for_sync $vg $lv1 -aux delay_dev $dev3 0 100 -lvconvert --yes -m +1 $vg/$lv1 $dev3 +aux delay_dev "$dev3" 0 100 +lvconvert --yes -m +1 $vg/$lv1 "$dev3" # should NOT allow both primaries to be removed -not lvconvert -m 0 $vg/$lv1 $dev1 $dev2 +not lvconvert -m 0 $vg/$lv1 "$dev1" "$dev2" # should allow primary + non-primary -lvconvert --yes -m 0 $vg/$lv1 $dev1 $dev3 -aux enable_dev $dev3 +lvconvert --yes -m 0 $vg/$lv1 "$dev1" "$dev3" +aux enable_dev "$dev3" lvremove -ff $vg ########################################### @@ -289,25 +289,25 @@ lvremove -ff $vg # RAID1: Replace up to n-1 devices - trying different combinations # Test for 2-way to 4-way RAID1 LVs for i in {1..3}; do - lvcreate --type raid1 -m $i -l 2 -n $lv1 $vg + lvcreate --type raid1 -m "$i" -l 2 -n $lv1 $vg - for j in $(seq $(($i + 1))); do # The number of devs to replace at once + for j in $(seq $(( i + 1 ))); do # The number of devs to replace at once for o in $(seq 0 $i); do # The offset into the device list replace="" devices=( $(get_image_pvs $vg $lv1) ) - for k in $(seq $j); do + for k in $(seq "$j"); do index=$((($k + $o) % ($i + 1))) replace="$replace --replace ${devices[$index]}" done aux wait_for_sync $vg $lv1 - if [ $j -ge $((i + 1)) ]; then + if [ "$j" -ge $(( i + 1 )) ]; then # Can't replace all at once. - not lvconvert $replace $vg/$lv1 + not lvconvert "$replace" $vg/$lv1 else - lvconvert $replace $vg/$lv1 + lvconvert "$replace" $vg/$lv1 fi done done |