summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* lvmnotify: add dbus notificationdev-dct-notify9David Teigland2016-02-2413-0/+166
| | | | | When a command modifies a PV or VG, it will send a dbus notification when the command is finished.
* configure: require sanlock 3.3.0David Teigland2016-02-241-1/+1
| | | | For a sanlock flag added in that version.
* lvmlockd: use new sanlock flag to avoid blockingDavid Teigland2016-02-241-4/+1
| | | | This flag allows sanlock requests to avoid all blocking.
* tests: include lvmlockd in default make checkdev-dct-make-checkDavid Teigland2016-02-231-1/+6
|
* lvmlockd: fix sparse snapshot caseDavid Teigland2016-02-231-0/+6
| | | | | A snapshot can be created without a real origin LV in this case, so there's no lock to use.
* cleanup: use sizeof instead of macro.Zdenek Kabelac2016-02-231-4/+4
| | | | | Keep the buffer size defined at a single place and then use its sizeof.
* cleanup: use braces around macro paramsZdenek Kabelac2016-02-231-3/+3
|
* coverity: ensure thin_pool_seg is not NULLZdenek Kabelac2016-02-231-1/+3
| | | | thin_pool_seg being NULL would be an internal error.
* coverity: use same arithmetic for both major and minorZdenek Kabelac2016-02-231-1/+1
| | | | Run all arithmetic in the same 'dev_t' type.
* coverity: check for dm_snprintfZdenek Kabelac2016-02-231-1/+2
| | | | Check return state like everywhere else.
* coverity: check cmd pointer existsZdenek Kabelac2016-02-231-1/+1
| | | | | Since in _report_init() we check few times for cmd != NULL keep it consistent and Coverity happier.
* coverity: ensure non-null pointers are usedZdenek Kabelac2016-02-231-1/+2
| | | | | | Here is too complex for Coverity to guess those pointers cannot be NULL, but it's very easy to add little checks here.
* coverity: drop unused assignmentsZdenek Kabelac2016-02-233-6/+7
|
* coverity: check for zero length bufferZdenek Kabelac2016-02-231-1/+4
| | | | | | When get_shared_library_path() would got zero length buffer, it could have underflow in size calc later. So just put extra small check for this case.
* coverity: check for info pointer existanceZdenek Kabelac2016-02-231-2/+4
| | | | | | Since we already check in few other places 'info' is not NULL, do the same for others - however when info would be NULL it more or less looks like internal error.
* coverity: drop unneeded headerZdenek Kabelac2016-02-231-1/+0
|
* libdm: fix string boundaryZdenek Kabelac2016-02-232-2/+4
| | | | | The test for string 'end' needs to account for ending \0, which also needs to fit <SIZE.
* lvmlockd: set default result valueDavid Teigland2016-02-231-0/+2
| | | | | The default error value should be set indicating an error.
* tests: updates for check_lvmlockdDavid Teigland2016-02-239-212/+152
| | | | | | | Move the lvmlockd-related setup functions into aux. For check_lvmlockd_test, start a new instance of lvmlockd --test for each shell test.
* make: Add check_lvmlockd_* targets to top-levelMarian Csontos2016-02-231-1/+1
|
* tests: add SKIP_WITH_LVMLOCKDDavid Teigland2016-02-23222-0/+249
| | | | to all tests that don't already used vgcreate $SHARED
* tests: check warn about belong is printedZdenek Kabelac2016-02-231-3/+6
|
* gcc: logical-op warning go awayZdenek Kabelac2016-02-232-6/+8
| | | | | Don't be too much inventive and shutdown gcc6 warning: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69602
* gcc: cleanup Wunused-const-variableZdenek Kabelac2016-02-231-1/+1
| | | | | | | | Use #define instead, since we do not require actually buffer needs to exists to eliminated new gcc6 warning: clvm.h:53:19: warning: ‘CLVMD_SOCKNAME’ defined but not used [-Wunused-const-variable]
* pvremove: add warn when removing PV in useZdenek Kabelac2016-02-232-36/+33
| | | | | | | | | | | | | Reshuffle messages during pvremove. Always print WARNING: when PV is in use so using options --force --force doesn't make this important user notification go away. Simplify variable 'used' usage (so older gcc doesn't warn about the use of unitilizied variable). Add some '.' into messages.
* cleanup: drop double ;Zdenek Kabelac2016-02-231-1/+1
|
* gcc: cleanup some sign warningsZdenek Kabelac2016-02-2312-21/+21
| | | | | | When comparing unsigned with int, the comparision is made as 'unsigned' type, so make it rather explicit which type is being compared.
* cache: enforce header checkZdenek Kabelac2016-02-232-1/+2
| | | | | | | Currently it's been checked for 'zero' header for thin-pool, but lets use it always for cache as well - since it's relatively 'cheap' detection of read 'error' problems as thin/cache tools currently do not work fast enough in this case.
* thin: fix read size compareZdenek Kabelac2016-02-232-1/+2
| | | | | Fix the compare with 'unsigned' sizeof() and error read -1 result. So the read error is correctly recognized.
* lvmdbusd: Initial unit test driver scriptTony Asleson2016-02-221-0/+60
| | | | | | It's disabled until we can fix it up. Signed-off-by: Tony Asleson <tasleson@redhat.com>
* lvmdbusd: Remove unlimited retriesTony Asleson2016-02-221-1/+11
| | | | | | | Change while to for loop to prevent the daemon from getting stuck when lvm is messed up. Signed-off-by: Tony Asleson <tasleson@redhat.com>
* lvmdbusd: Add env variable to use session busTony Asleson2016-02-222-2/+14
| | | | | | | | export LVMDBUSD_SESSION=True to run on the session bus instead of the system bus so that we can run the unit test without installing the dbus conf file. Signed-off-by: Tony Asleson <tasleson@redhat.com>
* lvmdbus: Make unit tests work in test envTony Asleson2016-02-221-33/+47
| | | | | | | Reduced the size of LVs created and use actual PE numbers instead of hard coding them to allow us to work with the loop back devices. Signed-off-by: Tony Asleson <tasleson@redhat.com>
* lvmdbusd: background.py, fix stdout parse errorTony Asleson2016-02-221-34/+51
| | | | | | | | | | | | | It appears that the output of lvconvert --merge can vary some. The code was blowing up as it was trying to parse a line of stdout to retrieve the % complete, but the line did not have the needed format and an execption was thrown. The uncaught exception caused the background thread to exit without updating the job object, which caused the client to hang forever waiting. Added a default exception handler to prevent unhandled execptions causing hangs and removed the parameter skip_first_line as it's no longer needed. The code checks to see if the line can be parsed before doing so. Signed-off-by: Tony Asleson <tasleson@redhat.com>
* lvmdbustest.py: Make executableTony Asleson2016-02-221-0/+0
| | | | Signed-off-by: Tony Asleson <tasleson@redhat.com>
* tests: fix clean up after lvmlockd testsDavid Teigland2016-02-222-2/+10
|
* lvmdbusd: Fix make install for python >= 3.5Marian Csontos2016-02-221-1/+1
| | | | python 3.5 renamed .pyo files to .opt-1.pyc.
* spec: Fix 04ab1fa572bb: Remove left-oversMarian Csontos2016-02-222-9/+12
|
* lvmlockd: invalidate name in lockspace struct after removeDavid Teigland2016-02-221-0/+7
| | | | | | | | | After the lockspace has been successfully removed, invalidate the name field in the lockspace struct. The struct remains on the list of lockspaces until the struct can be freed later. Until the struct is freed, its name will prevent another new lockspace from being created with the same name.
* test: add make check_lvmlockd_testDavid Teigland2016-02-2211-19/+100
| | | | | | | | Which runs lvmlockd in --test mode, without any lock manager. Also make some adjustments to the check_lvmlockd variations using the lock managds.
* tests: skip thin-flags test on 32bit el6 kernelZdenek Kabelac2016-02-222-0/+13
| | | | Until kernel is fixed, stop running test always hitting OOPS there.
* cleanup: use char arrays.Zdenek Kabelac2016-02-221-3/+3
|
* cleanup: indent changesZdenek Kabelac2016-02-221-19/+31
| | | | | | | | Some code indention. Use dm_strncpy() for simplier code. TODO: we could possibly use %32s for printing pvid... so maybe adding extra FMT_PVID....
* cleanup: libdm clang warningsZdenek Kabelac2016-02-221-2/+4
| | | | Add some extra clang pointer validation so we do not try deref NULL.
* libdm: grow with initialized struct contentZdenek Kabelac2016-02-222-5/+6
| | | | Coverity noticed struct hist has been copied uninitalized into mempool.
* lvmetad: fix error pathZdenek Kabelac2016-02-222-1/+2
| | | | | Coverity noticed the internal error path would be using uninit struct. So always make sure reply is initilized.
* post-releaseAlasdair G Kergon2016-02-214-2/+8
|
* pre-releasev2_02_143Alasdair G Kergon2016-02-214-4/+4
|
* lvmdbustest.py: resync latest changesTony Asleson2016-02-191-847/+1060
| | | | | | | This file update was missed, copied latest file from: https://github.com/tasleson/lvm-dubstep/blob/master/test/lvmdbustest.py Signed-off-by: Tony Asleson <tasleson@redhat.com>
* thin: fix update_pool_lv error pathZdenek Kabelac2016-02-192-7/+14
| | | | | | | | When update fails in suspend() (sending of messages fails because metadata space is full) call resume(), so the locking sequence works properly for clustering. Also failing deactivation should unlock memory.
View Lorry Controller Status