| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For completeness and consistency, adjust the behavior
for some variations of:
vgchange -aay --autoactivation event [vgname]
The current standard use is with a VG name arg, and the
command is only called when all pvs_online files exist.
This is the optimal case, in which only pvs_online devs
are read. This remains the same.
Clean up behaviors for some other unexpected uses of the
command:
. With no VG name arg, the command activates any VGs
that are complete according to pvs_online. If no
pvs_online files exist, it does nothing.
. If a VG name is used but no PVs online files exist for
the VG, or the PVs online files are incomplete, then
consider there could be a problem with the pvs_online
files, and fall back to a full label scan prior to
attempting the activation.
|
| |
|
|
|
|
|
|
|
|
| |
Part of the optimization to avoid a full dev_cache_scan requires
translating major:minor numbers to a device name. If this devno
translation fails, then fall back to doing a full dev_cache_scan
which is slower but certain to provide the info. This preserves
the most important part of the label scanning optimization in the
vgchange aay (avoiding dev_cache_scan is a relatively small part
of the optimized activation compared to label scanning.)
|
| |
|
|
|
|
| |
sysfs files for partitions are different from
whole devices and will require more work to translate
to device names.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port another optimization from pvscan -aay to vgchange -aay:
"pvscan: only add device args to dev cache"
This optimization avoids doing a full dev_cache_scan, and
instead populates dev-cache with only the devices in the
VG being activated.
This involves shifting the use of pvs_online files from
the hints interface up to the higher level label_scan
interface. This specialized label_scan is structured
around creating a list of devices from the pvs_online
files. Previously, a list of all devices was created
first, and then reduced based on the pvs_online files.
The initial step of listing all devices was slow when
thousands of devices are present on the system.
This optimization extends the previous optimization that
used pvs_online files to limit the devices that were
actually scanned (i.e. reading to identify the device):
"vgchange -aay: optimize device scan using pvs_online files"
|
| |
|
|
|
| |
in the pvscan --cache -aay command so that the use
of the command for event activation is explicit.
|
| |
|
|
|
| |
related to managing files in /run/lvm/pvs_online
and /run/lvm/vgs_online
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Port the old pvscan -aay scanning optimization to vgchange -aay.
The optimization uses pvs_online files created by pvscan --cache
to derive a list of devices to use when activating a VG. This
allows autoactivation of a VG to avoid scanning all devices, and
only scan the devices used by the VG itself. The optimization is
applied internally using the device hints interface.
The new option "--autoactivation event" is given to pvscan and
vgchange commands that are called by event activation. This
informs the command that it is being used for event activation,
so that it can apply checks and optimizations that are specific
to event activation. Those include:
- skipping the command if lvm.conf event_activation=0
- checking that a VG is complete before activating it
- using pvs_online files to limit device scanning
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The information in /run/lvm/pvs_online/<pvid> files can
be used to build a list of devices for a given VG.
The pvscan -aay command has long used this information to
activate a VG while scanning only devices in that VG, which
is an important optimization for autoactivation.
This patch implements the same thing through the existing
device hints interface, so that the optimization can be
applied elsewhere. A future patch will take advantage of
this optimization in vgchange -aay, which is now used in
place of pvscan -aay for event activation.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a device id is set for a device, using an idtype other
than devname, it means that sysfs has been used with the device
to match the device id. So, checking for a sysfs entry for the
device in filter-sysfs is redundant. For any other cases not
covered by this (e.g. devname ids), have filter-sysfs simply
stat /sys/dev/block/major:minor to test if the device exists
in sysfs.
The extensive processing done by filter-sysfs init is removed.
It was taking an immense amount of time with many devices, e.g.
. 1024 PVs in 520 VGs
. 520 concurrent vgchange -ay <vgname> commands
. vgchange scans only PVs in the named VG (based on pvs_online
files from a pending patch)
A large number of the vgchange commands were taking over 1 min,
and nearly half of that time was used by filter-sysfs init.
With this patch, the vgchange commands take about half the time.
|
| |
|
|
|
| |
which is no longer used after commit
"toollib: remove all devices list from process_each_pv"
|
| |
|
|
|
|
|
|
| |
Help bootstrapping existing shared vgs into the devices file.
Reading the vg in vgimportdevices would require locking to be
started, but vgchange lockstart won't see the vg if it's not
in the devices file. The lvmlockd locks are not protecting
vg modifications so skipping them here won't be a problem.
|
| |
|
|
| |
Signed-off-by: Christian Hesse <mail@eworm.de>
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Optimize the common pvscan --cache command by only adding
the necessary devs to dev-cache.
|
| | |
|
| |
|
|
|
| |
It appear on some systems the first found dev might not be actually for
the filesytem - so use a better way through _cache.st_dev.
|
| | |
|
| |
|
|
|
|
|
| |
As we are not using 'enable-compat' for anything, remove this section.
Also remove duplicated check for blkid.
Move setting of some AC_ARG_ENABLE defaults into the macro so it's always
defined.
|
| | |
|
| |
|
|
|
|
|
|
| |
When scanning configured /dev dir, avoid entring
directories with different filesystem.
This minimizes risk we will block on i.e. entring
directory with mount point.
|
| |
|
|
|
| |
At least 'stack' failure code path as the
function device_id_update_vg_uuid() is void.
|
| |
|
|
|
| |
Always resed sd_id128_t id and report warning in case
sd_id128_get_machine_app_specific() does not exit with 0.
|
| |
|
|
| |
Check pv2 is non-null before trying to deref its tags.
|
| |
|
|
|
| |
Do not try to 'discover' another error state, when ENOMEM
is already detected.
|
| | |
|
| |
|
|
|
| |
Before dereference of subcommand pointer, check it's not NULL
as coverity believes there exists theoretical path for this...
|
| |
|
|
| |
Check lvmcache info exists before calling lvmcache_del_save_bad_mda().
|
| |
|
|
| |
Newly added option --with-default-use-devices-file needs to use withval.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Enhance logic for checking supported systemd version,
while doing only a single check for systemd package.
For version checking use PKG_CHECK_EXISTS() macro.
Also use one pkg check for blkid.
Avoid checking version for thin/cache_check when tools are not present
on system.
|
| |
|
|
|
| |
Use TMPDIR for executing test and also ensure
all libraries linked to the test are from builddir.
|
| |
|
|
|
| |
Instead of guessing tmpfs usage, just directly try if we could
reopen file with O_DIRECT on the used filesystem.
|
| | |
|
| | |
|
| |
|
|
|
| |
Easier for automatic struct initialization = { 0 } without warns
from older gcc.
|
| |
|
|
|
| |
Missed [] around AS_IF internals,
Also missed to call pkg_config_init prior PKG_CHECK_MODULES().
|
| |
|
|
|
|
|
|
|
|
|
| |
Resolve event_activation configure option just once.
Do not print debug_devs about 'bad' filtering, when
actually filter already printed reason for skipping
Do not trace more then once about backup being disabled.
No debug when unlinked file does not exists in pvscan.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle automatically new setttings
--disable-systemd-journal
--disable-appmachineid
Both setting will check presence of apropriate header files.
In case they are present, build will try to automatically build with
them (adding systemd dependency)
User can anytime disabled them and drop systemd dependency.
Also add --with-default-use-devices-file configure option to
select automatically default value for this option.
For this moment keep default upstream as 0
|
| |
|
|
|
| |
For non-standard prefix dir use correct installation path
(so the python files are not installed into user's system).
|
| |
|
|
| |
Add more details about size difference.
|
| |
|
|
|
|
| |
Commit 5ea426e65628218569ede461312d80ba5d1c50fb handled case with
file path without '/' incorrectly - there is valid use-case so
switch 'log_error()' to valid code branch.
|
