| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
| |
When env.variable is set to empty getenv returns pointer to empty
string.
In tests it is expected this will produce undecorated debug.log instead
of debug.log__*
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
May be useful in case of deadlocks...
|
| |
|
|
|
| |
Explicit conversions are needed to align writes and reads on the stack.
int64_t is popped from stack while int was pushed.
|
| | |
|
| |
|
|
| |
instead of NULL value
|
| |
|
|
|
|
|
| |
lib/format1/import-export.c:167: var_deref_op: Dereferencing null pointer "vg->lvm1_system_id"
lib/cache/lvmetad.c:1023: var_deref_op: Dereferencing null pointer "this"
daemons/lvmlockd/lvmlockd-core.c:2659: check_after_deref: Null-checking "act" suggests that it may be null, but it has already been dereferenced on all paths leading to the check
/daemons/lvmetad/lvmetad-core.c:1024: check_after_deref: Null-checking "pvmeta" suggests that it may be null, but it has already been dereferenced on all paths leading to the check
|
| |
|
|
|
|
|
|
|
|
| |
systemd
If running lvmconf ... --startstopservice --mirrorservice in systemd
environment, handle lvm2-cmirrord accordingly. A typo in the script
caused the lvm2-cmirrord to not start/stop immediately, it was
only enabled/disabled (so the --startstopservice was ignored in this
case).
|
| |
|
|
|
|
| |
It was an optimization to avoid a pointless unlock call.
It affects all VGs, but was only intended to affect the
VG being stopped.
|
| |
|
|
|
| |
There are a number of log_error instances that are replaced
by log_debug because they are not errors.
|
| |
|
|
|
| |
see BZ 1241182, lvmlocal is searched before lvm.conf but after
lvm_<tag>.conf.
|
| | |
|
| |
|
|
|
| |
When formatting and printing info from lvmlockd.
Also fix some new line problems.
|
| |
|
|
|
|
| |
This prevents 'lvremove vgname' from attempting to remove the
hidden sanlock LV. Only vgremove should remove the hidden
sanlock LV holding the sanlock locks.
|
| |
|
|
|
| |
If the srcdir itself is a symlink the find would not return expected
value. So support also this config and use -L.
|
| |
|
|
|
|
| |
16e9b32c2f1a2d7e0f05a88981824ef0e7607965 incorrectly moved
free of opened descriptor out of if{} - resulted of
closing random file handle.
|
| |
|
|
|
|
|
| |
tools/polldaemon.c:457: array_null: Comparing an array to null is not useful: "lv->lvid.s"
The lv->lvid.s is never NULL. The check was supposed to be *lv->lvid.s
to check if the string is not empty.
|
| |
|
|
|
|
|
|
|
|
|
| |
... Using uninitialized value "lockd_state" when calling "lockd_vg"
(even though lockd_vg assigns 0 to the lockd_state, but it looks at
previous state of lockd_state just before that so we need to have
that properly initialized!)
libdm/libdm-report.c:2934: uninit_use_in_call: Using uninitialized value "tm". Field "tm.tm_gmtoff" is uninitialized when calling "_get_final_time".
daemons/lvmlockd/lvmlockctl.c:273: uninit_use_in_call: Using uninitialized element of array "r_name" when calling "format_info_r_action". (just added FIXME as this looks unfinished?)
|
| | |
|
| |
|
|
| |
lib/lvmpolld/lvmpolld-client.c:109: fallthrough: The above case falls through to this one
|
| |
|
|
|
|
| |
daemons/lvmlockd/lvmlockd-core.c:5709: error[uninitStructMember]: Uninitialized struct member: ds.....
daemons/lvmlockd/lvmlockd-core.c:799: error[uninitstring]: Dangerous usage of 'version' (strncpy doesn't always null-terminate it)
daemons/lvmlockd/lvmlockd-core.c:646: error[memleakOnRealloc]: Common realloc mistake: 'pollfd' nulled but not freed upon failure
|
| |
|
|
|
|
|
|
|
| |
lib/log/log.c:115: leaked_storage: Variable "st" going out of scope leaks the storage it points to
daemons/lvmpolld/lvmpolld-core.c:573: leaked_storage: Variable "cmdargv" going out of scope leaks the storage it points to
daemons/lvmlockd/lvmlockd-core.c:5341: leaked_handle: Handle variable "fd" going out of scope leaks the handle
daemons/lvmlockd/lvmlockctl.c:575: overwrite_var: Overwriting "able_vg_name" in "able_vg_name = strdup(optarg)" leaks the storage that "able_vg_name" points to
daemons/lvmlockd/lvmlockctl.c:571: overwrite_var: Overwriting "able_vg_name" in "able_vg_name = strdup(optarg)" leaks the storage that "able_vg_name" points to
daemons/lvmlockd/lvmlockctl.c:385: leaked_handle: Handle variable "s" going out of scope leaks the handle
|
| |
|
|
| |
appropriate
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before, we used general find_config_tree_node function to retrieve
array values. This had a downside where if the node was not found,
we had to insert default values directly in-situ after the
find_config_tree_node call. This way, we had two copies of default
values - one in config_settings.h and the other one directly in the
code where we found out that find_config_tree_node returned NULL and
hence we needed to fall back to defaults.
With separate find_config_tree_array used for array config values,
we keep all the defaults centrally in config_settings.h because
the new find_config_tree_array automatically returns these defaults
if it can't find any value set in the configuration.
This patch just makes the behaviour exactly the same for arrays as
for any other non-array type where we call find_config_tree_<type>
already, hence making the internal interface for handling array
values consistent with the rest of the config types.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
if lvm2 is built with debug memory options dm_free() is not
mapped directly to std library's free(). This may cause memory corruption
as a line buffer may get reallocated in getline with realloc.
This is a temporary hotfix. Other debug memory failure needs to
be investigated and explained.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Avoid stacking thins over thins.
|
| |
|
|
|
|
|
| |
Support newer cache tool which support new option
--clear-needs-check-flag.
Code does same as for thin_check.
|
| |
|
|
|
| |
This is not installed; it's only a developer utility
at this point.
|
| | |
|
| | |
|
| |
|
|
|
| |
It had been added as part of lvmlockd code, but it does
not seem particularly useful.
|
| |
|
|
|
|
|
|
|
|
| |
including the allow_override_lock_modes setting.
It was not possible to override default lock modes any longer,
since the command line options had already been removed.
A mechanism will probably be required later that puts part of
this back.
|
| |
|
|
|
| |
Because it only applies to lvmlockd requests, but
sounded too general.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Create a set of wrappers with embedded % such as
#define FMTu64 "%" PRIu64
|
| | |
|
| | |
|
| | |
|
| | |
|
