From 5817420781c3633a38f5c11515a47ac36d157b4d Mon Sep 17 00:00:00 2001 From: David Teigland Date: Thu, 7 Apr 2016 13:45:26 -0500 Subject: toollib: remove unneeded call in process_each_pv process_each_pv was doing: 1. lvmcache_seed_infos_from_lvmetad() sends pv_list request to lvmetad. 2. get_vgnameids() sends vg_list request to lvmetad. 3. _get_all_devices() first calls lvmcache_seed_infos_from_lvmetad(), which is a no-op if it's already been called. Because get_vgnameids() does not use the information from lvmcache_seed_infos_from_lvmetad(), it does not need to be called prior to get_all_devices where it is actually needed. --- tools/toollib.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/toollib.c b/tools/toollib.c index ea6f4bc39..af6054751 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -3356,12 +3356,6 @@ int process_each_pv(struct cmd_context *cmd, dev_cache_full_scan(cmd->full_filter); } - /* - * Need pvid's set on all PVs before processing so that pvid's - * can be compared to find duplicates while processing. - */ - lvmcache_seed_infos_from_lvmetad(cmd); - if (!get_vgnameids(cmd, &all_vgnameids, only_this_vgname, 1)) { stack; return ret; -- cgit v1.2.1