From 604b4bef610b1984e85d818a7d7e243e30abea32 Mon Sep 17 00:00:00 2001 From: Marian Csontos Date: Wed, 14 Feb 2018 12:46:08 +0100 Subject: mirror: Add deprecation warning for mirrored log --- lib/metadata/mirror.c | 4 ++++ tools/lvconvert.c | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index 38c3df679..71d3457bc 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -1945,6 +1945,10 @@ int add_mirror_log(struct cmd_context *cmd, struct logical_volume *lv, return 1; } + if (log_count > 1) { + log_warn("Log type \"mirrored\" is DEPRECATED and will be removed in the future. Use RAID1 LV or disk log instead."); + } + if (!(parallel_areas = build_parallel_areas_from_lv(lv, 0, 0))) return_0; diff --git a/tools/lvconvert.c b/tools/lvconvert.c index fee0a4ef8..e18ec236f 100644 --- a/tools/lvconvert.c +++ b/tools/lvconvert.c @@ -1216,6 +1216,11 @@ static int _lvconvert_mirrors(struct cmd_context *cmd, (old_log_count == new_log_count)) return 1; + if ((old_log_count != new_log_count) && + (new_log_count == MIRROR_LOG_MIRRORED)) { + log_warn("Log type \"mirrored\" is DEPRECATED and will be removed in the future. Use RAID1 LV or disk log instead."); + } + if (!_lvconvert_mirrors_aux(cmd, lv, lp, NULL, new_mimage_count, new_log_count, lp->pvh)) return_0; -- cgit v1.2.1