From cb798ee1c102aadde93965a894c5aa59d4e76e4a Mon Sep 17 00:00:00 2001 From: David Teigland Date: Wed, 12 Jan 2022 16:46:26 -0600 Subject: lvmcache: remove lvmcache_update_vg_from_write After a vg_write, this function was used to attempt to make lvmcache data match the new state written to disk. It was not updated correctly in a many or most cases, and the resulting lvmcache is not actually used after vg_write, making the update unnecessary. --- lib/metadata/metadata.c | 7 ------- 1 file changed, 7 deletions(-) (limited to 'lib/metadata') diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index f01a0bea6..7e5605820 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -3102,7 +3102,6 @@ static int _vg_commit_mdas(struct volume_group *vg) DM_LIST_INIT(ignored); int failed = 0; int good = 0; - int cache_updated = 0; /* Rearrange the metadata_areas_in_use so ignored mdas come first. */ dm_list_iterate_items_safe(mda, tmda, &vg->fid->metadata_areas_in_use) @@ -3123,12 +3122,6 @@ static int _vg_commit_mdas(struct volume_group *vg) failed = 1; } else good++; - - /* Update cache first time we succeed */ - if (!failed && !cache_updated) { - lvmcache_update_vg_from_write(vg); - cache_updated = 1; - } } if (good) return 1; -- cgit v1.2.1