From f6f2737015746b1b6c7fbd0d297a4596c584749b Mon Sep 17 00:00:00 2001 From: David Teigland Date: Tue, 11 Oct 2022 11:50:47 -0500 Subject: lvreduce: require active LV when no fs option is used Without an --fs option set, make lvreduce of an inactive LV fail and report that the LV must be active. --- lib/metadata/lv_manip.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lib/metadata') diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index d6452e849..db97a019c 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -6873,6 +6873,10 @@ int lv_resize(struct cmd_context *cmd, struct logical_volume *lv, is_active = lv_is_active(lv_top); if (is_reduce && !is_active && !strcmp(lp->fsopt, "checksize")) { + if (!lp->user_set_fs) { + log_error("The LV must be active to safely reduce, or use --fs checksize."); + goto out; + } lv_top->status |= LV_TEMPORARY; if (!activate_lv(cmd, lv_top)) { log_error("Failed to activate %s to check for fs.", display_lvname(lv_top)); -- cgit v1.2.1