<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/mariadb-git.git/sql/sql_error.h, branch preview-10.8-MDEV-14425-innodb</title>
<subtitle>github.com: MariaDB/server.git
</subtitle>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/'/>
<entry>
<title>refactor THD::raise_condition() family</title>
<updated>2021-10-26T15:29:40+00:00</updated>
<author>
<name>Sergei Golubchik</name>
<email>serg@mariadb.org</email>
</author>
<published>2021-10-08T16:43:56+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=b73b736506109ecf09761e5c2b2693810a0b9ea6'/>
<id>b73b736506109ecf09761e5c2b2693810a0b9ea6</id>
<content type='text'>
to remove

Sql_condition*
raise_condition(const Sql_condition *cond)
{
  Sql_condition *raised= raise_condition(cond-&gt;get_sql_errno(),
                                         cond-&gt;get_sqlstate(),
                                         cond-&gt;get_level(),
                                         *cond,
                                         cond-&gt;get_message_text());
  return raised;
}
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
to remove

Sql_condition*
raise_condition(const Sql_condition *cond)
{
  Sql_condition *raised= raise_condition(cond-&gt;get_sql_errno(),
                                         cond-&gt;get_sqlstate(),
                                         cond-&gt;get_level(),
                                         *cond,
                                         cond-&gt;get_message_text());
  return raised;
}
</pre>
</div>
</content>
</entry>
<entry>
<title>MDEV-26635 ROW_NUMBER is not 0 for errors not caused because of rows</title>
<updated>2021-10-26T15:29:40+00:00</updated>
<author>
<name>Sergei Golubchik</name>
<email>serg@mariadb.org</email>
</author>
<published>2021-10-02T18:50:18+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=a398fcbff6f73394135bc52d2197dc80a1f13fbf'/>
<id>a398fcbff6f73394135bc52d2197dc80a1f13fbf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>MDEV-26606: ROW_NUMBER property value isn't passed from inside a stored</title>
<updated>2021-10-06T18:26:06+00:00</updated>
<author>
<name>Rucha Deodhar</name>
<email>rucha.deodhar@mariadb.com</email>
</author>
<published>2021-09-25T20:00:36+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=479e303ef3e76a984d7885969863157b220c49d0'/>
<id>479e303ef3e76a984d7885969863157b220c49d0</id>
<content type='text'>
procedure

Analysis: m_current_row_for_warning is reset to 1 during cleanup phase of
stored procedure. When we perform a copy because some statement of procedure
created warning, this reset value is passed to push_warning().
Hence the output is always 1.
Fix: Add a parameter in relevant functions to pass correct value of
row_number and don't use m_current_row_for_warning directly.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
procedure

Analysis: m_current_row_for_warning is reset to 1 during cleanup phase of
stored procedure. When we perform a copy because some statement of procedure
created warning, this reset value is passed to push_warning().
Hence the output is always 1.
Fix: Add a parameter in relevant functions to pass correct value of
row_number and don't use m_current_row_for_warning directly.
</pre>
</div>
</content>
</entry>
<entry>
<title>MDEV-26611: ERROR_INDEX isn't intuitively clear</title>
<updated>2021-10-05T07:14:55+00:00</updated>
<author>
<name>Rucha Deodhar</name>
<email>rucha.deodhar@mariadb.com</email>
</author>
<published>2021-09-29T08:48:40+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=d5e606c60545eae8ab86d68e9d432c92450c3122'/>
<id>d5e606c60545eae8ab86d68e9d432c92450c3122</id>
<content type='text'>
Fixup for MDEV-10075

Analysis: ERROR_INDEX implemented in MDEV-10075 was not intuitively clear.

Fix: changed parser to use ROW_NUMBER instead of ERROR_INDEX. Removed
ERROR_INDEX and ERROR_INDEX_SYM from related files. Changed m_error_index
to m_row_number.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixup for MDEV-10075

Analysis: ERROR_INDEX implemented in MDEV-10075 was not intuitively clear.

Fix: changed parser to use ROW_NUMBER instead of ERROR_INDEX. Removed
ERROR_INDEX and ERROR_INDEX_SYM from related files. Changed m_error_index
to m_row_number.
</pre>
</div>
</content>
</entry>
<entry>
<title>MDEV-10075: Provide index of error causing error in array INSERT</title>
<updated>2021-09-16T11:38:48+00:00</updated>
<author>
<name>Sergei Golubchik</name>
<email>serg@mariadb.org</email>
</author>
<published>2021-09-15T13:54:49+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=d552e092c9f3e20da078d1b62b976f629f73d3a4'/>
<id>d552e092c9f3e20da078d1b62b976f629f73d3a4</id>
<content type='text'>
use existing Warning_info::m_current_row_for_warning instead
of a newly introduced counter.

But use m_current_row_for_warning to count rows also in the parser
and during prepare.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
use existing Warning_info::m_current_row_for_warning instead
of a newly introduced counter.

But use m_current_row_for_warning to count rows also in the parser
and during prepare.
</pre>
</div>
</content>
</entry>
<entry>
<title>MDEV-10075: Provide index of error causing error in array INSERT</title>
<updated>2021-09-15T06:55:34+00:00</updated>
<author>
<name>Rucha Deodhar</name>
<email>rucha.deodhar@mariadb.com</email>
</author>
<published>2021-07-31T07:25:21+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=ea06c67a49cf6f4b8daa7287454faba6b7cae874'/>
<id>ea06c67a49cf6f4b8daa7287454faba6b7cae874</id>
<content type='text'>
Extended the parser for GET DIAGNOSTICS to use ERROR_INDEX to get
warning/error index.
Error information is stored in Sql_condition. So it can be used to
store the index of warning/error too. THD::current_insert_index keeps a
track of count for each row that is processed or going to be inserted in the
table (or first row in case of prepare phase). When an error occurs,
first we need to fetch corrected error index (using correct_error_index())
for an error number. This is needed because in prepare phase, the error
may not be because of rows/values. In such case, correct value of
error_index should be 0. Once correct value if fetched, assign it to
Sql_condition::error_index when the object is created during error/warning.
This error_index variable is returned when ERROR_INDEX is used in
GET DIAGNOSTICS.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Extended the parser for GET DIAGNOSTICS to use ERROR_INDEX to get
warning/error index.
Error information is stored in Sql_condition. So it can be used to
store the index of warning/error too. THD::current_insert_index keeps a
track of count for each row that is processed or going to be inserted in the
table (or first row in case of prepare phase). When an error occurs,
first we need to fetch corrected error index (using correct_error_index())
for an error number. This is needed because in prepare phase, the error
may not be because of rows/values. In such case, correct value of
error_index should be 0. Once correct value if fetched, assign it to
Sql_condition::error_index when the object is created during error/warning.
This error_index variable is returned when ERROR_INDEX is used in
GET DIAGNOSTICS.
</pre>
</div>
</content>
</entry>
<entry>
<title>merge 10.5 to 10.6</title>
<updated>2021-07-16T20:12:09+00:00</updated>
<author>
<name>Vladislav Vaintroub</name>
<email>wlad@mariadb.com</email>
</author>
<published>2021-07-16T20:12:09+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=e7f4daf88c4348bb018d04d298b104617554f310'/>
<id>e7f4daf88c4348bb018d04d298b104617554f310</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>MDEV-21916: COM_STMT_BULK_EXECUTE with RETURNING insert wrong values</title>
<updated>2021-07-15T14:28:13+00:00</updated>
<author>
<name>Oleksandr Byelkin</name>
<email>sanja@mariadb.com</email>
</author>
<published>2020-06-22T16:21:21+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=a7d880f0b095939118594ecbeba953959ae8e351'/>
<id>a7d880f0b095939118594ecbeba953959ae8e351</id>
<content type='text'>
The problem is that array binding uses net buffer to read parameters for each
execution while each execiting with RETURNING write in the same buffer.

Solution is to allocate new net buffer to avoid changing buffer we are reading
from.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The problem is that array binding uses net buffer to read parameters for each
execution while each execiting with RETURNING write in the same buffer.

Solution is to allocate new net buffer to avoid changing buffer we are reading
from.
</pre>
</div>
</content>
</entry>
<entry>
<title>Added ErrConvString.lex_cstring() to simplify code</title>
<updated>2021-05-19T20:27:29+00:00</updated>
<author>
<name>Monty</name>
<email>monty@mariadb.org</email>
</author>
<published>2020-08-14T17:22:43+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=b3bc02f923f6002e6a5bd6446b80575292e1b0c7'/>
<id>b3bc02f923f6002e6a5bd6446b80575292e1b0c7</id>
<content type='text'>
This allows us to use String::append() without using strlen().

The changes to the ErrConvString class where done by Alexander Barkov
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This allows us to use String::append() without using strlen().

The changes to the ErrConvString class where done by Alexander Barkov
</pre>
</div>
</content>
</entry>
<entry>
<title>MDEV-21612 - remove COM_MULTI from server and C/C</title>
<updated>2020-07-14T09:16:24+00:00</updated>
<author>
<name>Vladislav Vaintroub</name>
<email>wlad@mariadb.com</email>
</author>
<published>2020-07-08T16:31:00+00:00</published>
<link rel='alternate' type='text/html' href='http://trove.baserock.org/cgit/delta/mariadb-git.git/commit/?id=b0d2a59d9ab6e68461ba01becd791e1ab6e8ae27'/>
<id>b0d2a59d9ab6e68461ba01becd791e1ab6e8ae27</id>
<content type='text'>
The COM_MULTI did not take off. No connector is using it.
Remove related code from server, and client.
If anything it is a step simplification of already-bloated
dispatch_command(), and related code.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The COM_MULTI did not take off. No connector is using it.
Remove related code from server, and client.
If anything it is a step simplification of already-bloated
dispatch_command(), and related code.
</pre>
</div>
</content>
</entry>
</feed>
