diff options
| author | Vladislav Vaintroub <wlad@mariadb.com> | 2022-12-14 13:34:11 +0100 |
|---|---|---|
| committer | Vladislav Vaintroub <wlad@mariadb.com> | 2022-12-14 13:34:11 +0100 |
| commit | c1fd082e9c7369f4511eb5a52e58cb15489caa74 (patch) | |
| tree | d46316167fff4abd99cab40071f5b92039765cf2 | |
| parent | 0aca3012a13fb6dcd438d47a5b9d67369dc59535 (diff) | |
| download | mariadb-git-c1fd082e9c7369f4511eb5a52e58cb15489caa74.tar.gz | |
MDEV-25341 post-fix. Don't use DiscardVirtualMemory on Windows.
This turns out to be a too expensive call to use for every freed page,
especially under global buffer pool mutex protection.
Also, the usefulness of proactive shrinking of the buffer pool on Windows
this is seems questionable - there is no OOM killer, and the OS will
shrink working sets itself.
| -rw-r--r-- | storage/innobase/include/buf0buf.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/storage/innobase/include/buf0buf.h b/storage/innobase/include/buf0buf.h index 2dd6935241e..eb84aff8354 100644 --- a/storage/innobase/include/buf0buf.h +++ b/storage/innobase/include/buf0buf.h @@ -662,8 +662,6 @@ public: MEM_NOACCESS(frame, srv_page_size); #ifdef MADV_FREE madvise(frame, srv_page_size, MADV_FREE); -#elif defined(_WIN32) - DiscardVirtualMemory(frame, srv_page_size); #endif } |