summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorram@gw.mysql.r18.ru <>2004-10-21 17:02:24 +0500
committerram@gw.mysql.r18.ru <>2004-10-21 17:02:24 +0500
commit61c7767786e626855f8b8c2558a97db6cc5db644 (patch)
treecc1d9f6ec82546e9be474e94ed72da5e649bfad8
parenteda3eb378d2d998b3899f91fedfc0017270178e6 (diff)
downloadmariadb-git-61c7767786e626855f8b8c2558a97db6cc5db644.tar.gz
A fix (bug #4802 prompt in mysql client shows wrong database after dropping default db).
-rw-r--r--client/mysql.cc38
-rw-r--r--include/mysql_com.h1
-rw-r--r--sql/sql_db.cc2
3 files changed, 23 insertions, 18 deletions
diff --git a/client/mysql.cc b/client/mysql.cc
index 05d5d1355ad..18dc4dd76cb 100644
--- a/client/mysql.cc
+++ b/client/mysql.cc
@@ -1574,6 +1574,22 @@ static int reconnect(void)
return 0;
}
+static void get_current_db()
+{
+ MYSQL_RES *res;
+
+ my_free(current_db, MYF(MY_ALLOW_ZERO_PTR));
+ current_db= NULL;
+ /* In case of error below current_db will be NULL */
+ if (!mysql_query(&mysql, "SELECT DATABASE()") &&
+ (res= mysql_use_result(&mysql)))
+ {
+ MYSQL_ROW row= mysql_fetch_row(res);
+ if (row[0])
+ current_db= my_strdup(row[0], MYF(MY_WME));
+ mysql_free_result(res);
+ }
+}
/***************************************************************************
The different commands
@@ -1899,6 +1915,9 @@ com_go(String *buffer,char *line __attribute__((unused)))
if (err >= 1)
error= put_error(&mysql);
+ if (!status.batch && (mysql.server_status & SERVER_STATUS_DB_DROPPED))
+ get_current_db();
+
return error; /* New command follows */
}
@@ -2614,24 +2633,7 @@ com_use(String *buffer __attribute__((unused)), char *line)
under our feet, for example if DROP DATABASE or RENAME DATABASE
(latter one not yet available by the time the comment was written)
*/
- /* Let's reset current_db, assume it's gone */
- my_free(current_db, MYF(MY_ALLOW_ZERO_PTR));
- current_db= 0;
- /*
- We don't care about in case of an error below because current_db
- was just set to 0.
- */
- if (!mysql_query(&mysql, "SELECT DATABASE()") &&
- (res= mysql_use_result(&mysql)))
- {
- row= mysql_fetch_row(res);
- if (row[0])
- {
- current_db= my_strdup(row[0], MYF(MY_WME));
- }
- (void) mysql_fetch_row(res); // Read eof
- mysql_free_result(res);
- }
+ get_current_db();
if (!current_db || cmp_database(charset_info, current_db,tmp))
{
diff --git a/include/mysql_com.h b/include/mysql_com.h
index 449cd0ba396..6fc1d106197 100644
--- a/include/mysql_com.h
+++ b/include/mysql_com.h
@@ -127,6 +127,7 @@ enum enum_server_command
#define SERVER_MORE_RESULTS_EXISTS 8 /* Multi query - next query exists */
#define SERVER_QUERY_NO_GOOD_INDEX_USED 16
#define SERVER_QUERY_NO_INDEX_USED 32
+#define SERVER_STATUS_DB_DROPPED 256 /* A database was dropped */
#define MYSQL_ERRMSG_SIZE 512
#define NET_READ_TIMEOUT 30 /* Timeout on read */
diff --git a/sql/sql_db.cc b/sql/sql_db.cc
index 426f7d36633..e5b426ef508 100644
--- a/sql/sql_db.cc
+++ b/sql/sql_db.cc
@@ -634,7 +634,9 @@ int mysql_rm_db(THD *thd,char *db,bool if_exists, bool silent)
thd->clear_error();
mysql_bin_log.write(&qinfo);
}
+ thd->server_status|= SERVER_STATUS_DB_DROPPED;
send_ok(thd, (ulong) deleted);
+ thd->server_status&= !SERVER_STATUS_DB_DROPPED;
}
exit: