summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSachin Setiya <sachinsetia1001@gmail.com>2016-12-14 13:57:05 +0530
committerSachin Setiya <sachinsetia1001@gmail.com>2016-12-14 13:57:05 +0530
commitffdd1e9d888edc4e147c3b316a87468b000f8dd4 (patch)
tree72d97d1834050c1535f0956760081520fb8e488c
parente156ea1b9517dd155f68f8d683704ecf5370346a (diff)
downloadmariadb-git-ffdd1e9d888edc4e147c3b316a87468b000f8dd4.tar.gz
Revert "MDEV-11016 wsrep_node_is_ready() check is too strict"
This reverts commit 52ea5ad865b4f6b4b37176296a3be0a716c5109a. # Conflicts: # mysql-test/suite/galera/r/galera_var_dirty_reads.result # mysql-test/suite/galera/t/galera_var_dirty_reads.test # sql/sql_parse.cc
-rw-r--r--mysql-test/suite/galera/r/galera_var_dirty_reads.result16
-rw-r--r--mysql-test/suite/galera/t/galera_var_dirty_reads.test13
-rw-r--r--sql/sql_parse.cc4
3 files changed, 0 insertions, 33 deletions
diff --git a/mysql-test/suite/galera/r/galera_var_dirty_reads.result b/mysql-test/suite/galera/r/galera_var_dirty_reads.result
index c0ffb2d4860..6d703c8cf95 100644
--- a/mysql-test/suite/galera/r/galera_var_dirty_reads.result
+++ b/mysql-test/suite/galera/r/galera_var_dirty_reads.result
@@ -18,22 +18,6 @@ SET @@session.wsrep_dirty_reads=ON;
SELECT * FROM t1;
i
1
-#
-# MDEV-11016: wsrep_node_is_ready() check is too strict
-#
-SET @@session.wsrep_dirty_reads=OFF;
-SELECT 2;
-2
-2
-SELECT 2+2 from DUAL;
-2+2
-4
-SET @VAR=1;
-SELECT @VAR;
-@VAR
-1
-SELECT @@max_allowed_packet;
-SELECT SYSDATE() from DUAL;
SELECT * FROM t1;
i
1
diff --git a/mysql-test/suite/galera/t/galera_var_dirty_reads.test b/mysql-test/suite/galera/t/galera_var_dirty_reads.test
index 7a76a71a265..dfd8d5ecf29 100644
--- a/mysql-test/suite/galera/t/galera_var_dirty_reads.test
+++ b/mysql-test/suite/galera/t/galera_var_dirty_reads.test
@@ -36,19 +36,6 @@ SET @@session.wsrep_dirty_reads=ON;
SELECT * FROM t1;
---echo #
---echo # MDEV-11016: wsrep_node_is_ready() check is too strict
---echo #
-SET @@session.wsrep_dirty_reads=OFF;
-SELECT 2;
-SELECT 2+2 from DUAL;
-SET @VAR=1;
-SELECT @VAR;
---disable_result_log
-SELECT @@max_allowed_packet;
-SELECT SYSDATE() from DUAL;
---enable_result_log
-
--disable_query_log
--eval SET @@global.wsrep_cluster_address = '$wsrep_cluster_address_saved'
--enable_query_log
diff --git a/sql/sql_parse.cc b/sql/sql_parse.cc
index 53350751d79..4ed1b7a5323 100644
--- a/sql/sql_parse.cc
+++ b/sql/sql_parse.cc
@@ -2635,15 +2635,11 @@ mysql_execute_command(THD *thd)
/*
Bail out if DB snapshot has not been installed. We however,
allow SET and SHOW queries.
- SHOW and SELECT queries (only if wsrep_dirty_reads is set or when it
- does not access ant table)
*/
if (thd->variables.wsrep_on && !thd->wsrep_applier && !wsrep_ready &&
lex->sql_command != SQLCOM_SET_OPTION &&
!(thd->variables.wsrep_dirty_reads &&
lex->sql_command == SQLCOM_SELECT) &&
- !(lex->sql_command == SQLCOM_SELECT &&
- !all_tables) &&
!wsrep_is_show_query(lex->sql_command))
{
my_message(ER_UNKNOWN_COM_ERROR,