summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Lindström <jan.lindstrom@mariadb.com>2016-06-02 11:43:50 +0300
committerJan Lindström <jan.lindstrom@mariadb.com>2016-06-02 11:43:50 +0300
commit54f3e18f6e88bfae993749569104b4c89f0ea9ab (patch)
tree8c9ad6ba91e6785d6bfdcf8c2afab4ec012f72e2
parent54332b27934fc7a4db5d08cbcbc856b28a676f35 (diff)
parenta0b11b90338317796387c4a756f863f8f7495f90 (diff)
downloadmariadb-git-54f3e18f6e88bfae993749569104b4c89f0ea9ab.tar.gz
Merge pull request #179 from grooverdan/10.2-remove_btr_search_n_succ_AND_hash_fail
MDEV-10168 - Remove btr_search_n_succ and btr_search_n_hash_fail counters
-rw-r--r--storage/innobase/btr/btr0sea.cc14
-rw-r--r--storage/innobase/include/btr0sea.h7
-rw-r--r--storage/xtradb/btr/btr0sea.cc12
-rw-r--r--storage/xtradb/include/btr0sea.h7
4 files changed, 0 insertions, 40 deletions
diff --git a/storage/innobase/btr/btr0sea.cc b/storage/innobase/btr/btr0sea.cc
index dcb508a7f29..1dd9d9862a7 100644
--- a/storage/innobase/btr/btr0sea.cc
+++ b/storage/innobase/btr/btr0sea.cc
@@ -50,13 +50,6 @@ UNIV_INTERN char btr_search_enabled = TRUE;
/** A dummy variable to fool the compiler */
UNIV_INTERN ulint btr_search_this_is_zero = 0;
-#ifdef UNIV_SEARCH_PERF_STAT
-/** Number of successful adaptive hash index lookups */
-UNIV_INTERN ulint btr_search_n_succ = 0;
-/** Number of failed adaptive hash index lookups */
-UNIV_INTERN ulint btr_search_n_hash_fail = 0;
-#endif /* UNIV_SEARCH_PERF_STAT */
-
/** padding to prevent other memory update
hotspots from residing on the same memory
cache line as btr_search_latch */
@@ -651,10 +644,6 @@ btr_search_info_update_slow(
if (cursor->flag == BTR_CUR_HASH_FAIL) {
/* Update the hash node reference, if appropriate */
-#ifdef UNIV_SEARCH_PERF_STAT
- btr_search_n_hash_fail++;
-#endif /* UNIV_SEARCH_PERF_STAT */
-
rw_lock_x_lock(&btr_search_latch);
btr_search_update_hash_ref(info, block, cursor);
@@ -1010,9 +999,6 @@ btr_search_guess_on_hash(
#endif
info->last_hash_succ = TRUE;
-#ifdef UNIV_SEARCH_PERF_STAT
- btr_search_n_succ++;
-#endif
if (UNIV_LIKELY(!has_search_latch)
&& buf_page_peek_if_too_old(&block->page)) {
diff --git a/storage/innobase/include/btr0sea.h b/storage/innobase/include/btr0sea.h
index 848bde451a0..c9288295ec0 100644
--- a/storage/innobase/include/btr0sea.h
+++ b/storage/innobase/include/btr0sea.h
@@ -256,13 +256,6 @@ struct btr_search_sys_t{
/** The adaptive hash index */
extern btr_search_sys_t* btr_search_sys;
-#ifdef UNIV_SEARCH_PERF_STAT
-/** Number of successful adaptive hash index lookups */
-extern ulint btr_search_n_succ;
-/** Number of failed adaptive hash index lookups */
-extern ulint btr_search_n_hash_fail;
-#endif /* UNIV_SEARCH_PERF_STAT */
-
/** After change in n_fields or n_bytes in info, this many rounds are waited
before starting the hash analysis again: this is to save CPU time when there
is no hope in building a hash index. */
diff --git a/storage/xtradb/btr/btr0sea.cc b/storage/xtradb/btr/btr0sea.cc
index ac5e9aec67b..f28c61b3781 100644
--- a/storage/xtradb/btr/btr0sea.cc
+++ b/storage/xtradb/btr/btr0sea.cc
@@ -53,13 +53,6 @@ UNIV_INTERN ulint btr_search_index_num;
/** A dummy variable to fool the compiler */
UNIV_INTERN ulint btr_search_this_is_zero = 0;
-#ifdef UNIV_SEARCH_PERF_STAT
-/** Number of successful adaptive hash index lookups */
-UNIV_INTERN ulint btr_search_n_succ = 0;
-/** Number of failed adaptive hash index lookups */
-UNIV_INTERN ulint btr_search_n_hash_fail = 0;
-#endif /* UNIV_SEARCH_PERF_STAT */
-
/** padding to prevent other memory update
hotspots from residing on the same memory
cache line as btr_search_latch */
@@ -698,10 +691,6 @@ btr_search_info_update_slow(
if (cursor->flag == BTR_CUR_HASH_FAIL) {
/* Update the hash node reference, if appropriate */
-#ifdef UNIV_SEARCH_PERF_STAT
- btr_search_n_hash_fail++;
-#endif /* UNIV_SEARCH_PERF_STAT */
-
rw_lock_x_lock(btr_search_get_latch(cursor->index));
btr_search_update_hash_ref(info, block, cursor);
@@ -1059,7 +1048,6 @@ btr_search_guess_on_hash(
info->last_hash_succ = TRUE;
#ifdef UNIV_SEARCH_PERF_STAT
- btr_search_n_succ++;
#endif
if (UNIV_LIKELY(!has_search_latch)
&& buf_page_peek_if_too_old(&block->page)) {
diff --git a/storage/xtradb/include/btr0sea.h b/storage/xtradb/include/btr0sea.h
index d40094461ff..6e4ef16cf79 100644
--- a/storage/xtradb/include/btr0sea.h
+++ b/storage/xtradb/include/btr0sea.h
@@ -332,13 +332,6 @@ struct btr_search_sys_t{
/** The adaptive hash index */
extern btr_search_sys_t* btr_search_sys;
-#ifdef UNIV_SEARCH_PERF_STAT
-/** Number of successful adaptive hash index lookups */
-extern ulint btr_search_n_succ;
-/** Number of failed adaptive hash index lookups */
-extern ulint btr_search_n_hash_fail;
-#endif /* UNIV_SEARCH_PERF_STAT */
-
/** After change in n_fields or n_bytes in info, this many rounds are waited
before starting the hash analysis again: this is to save CPU time when there
is no hope in building a hash index. */