diff options
| author | Marko Mäkelä <marko.makela@mariadb.com> | 2019-07-01 13:27:12 +0300 |
|---|---|---|
| committer | Marko Mäkelä <marko.makela@mariadb.com> | 2019-07-01 13:27:12 +0300 |
| commit | 5a136d84f35f9863c2344772f107be22c8aaa05a (patch) | |
| tree | 6d298e83db672f41c784bfdb4a97844b15703a00 | |
| parent | 85d0a1955fe9b9cf87fb6cbfe84d684bff2b24cc (diff) | |
| download | mariadb-git-5a136d84f35f9863c2344772f107be22c8aaa05a.tar.gz | |
MDEV-19766: Disable page dump output in debug builds
The test innodb.leaf_page_corrupted_during_recovery
fails on buildbot with
Warning 1406 Data too long for column 'line' at row 10
line
len 16384; hex ...
because of a page dumps that InnoDB is generating for a corrupted page
Since this test is using debug instrumentation, we will solve the
issue by disabling page dumps in debug builds altogether. Users of
debug builds will likely know how to extract page dumps in other means.
Page dump output could sometimes be useful when diagnosing problems
that users are facing. Hence we will keep the page dump output in
non-debug (release) builds.
| -rw-r--r-- | storage/innobase/buf/buf0buf.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/storage/innobase/buf/buf0buf.cc b/storage/innobase/buf/buf0buf.cc index 1840066707f..cb1e9818d87 100644 --- a/storage/innobase/buf/buf0buf.cc +++ b/storage/innobase/buf/buf0buf.cc @@ -1273,11 +1273,13 @@ buf_page_print(const byte* read_buf, const page_size_t& page_size) { dict_index_t* index; +#ifndef UNIV_DEBUG ib::info() << "Page dump in ascii and hex (" << page_size.physical() << " bytes):"; ut_print_buf(stderr, read_buf, page_size.physical()); fputs("\nInnoDB: End of page dump\n", stderr); +#endif if (page_size.is_compressed()) { /* Print compressed page. */ |