diff options
author | Alexey Yurchenko <alexey.yurchenko@galeracluster.com> | 2020-12-30 23:51:29 +0200 |
---|---|---|
committer | Jan Lindström <jan.lindstrom@mariadb.com> | 2021-01-07 17:41:21 +0200 |
commit | 033f8d13ce6bc2a8003ada5bb51b28b47cd64949 (patch) | |
tree | 18bb8d63d1777925ecffdad357cb7e0e8b22f7f0 | |
parent | 7edbd27258cd2f73887b1723e515139e654cf37e (diff) | |
download | mariadb-git-033f8d13ce6bc2a8003ada5bb51b28b47cd64949.tar.gz |
Update wsrep-lib (new logger interface)
Ensure consistent use of logging macros in wsrep-related code
Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>
-rw-r--r-- | sql/wsrep_mysqld.cc | 36 | ||||
-rw-r--r-- | sql/wsrep_mysqld.h | 28 | ||||
-rw-r--r-- | sql/wsrep_server_service.cc | 11 | ||||
m--------- | wsrep-lib | 0 |
4 files changed, 40 insertions, 35 deletions
diff --git a/sql/wsrep_mysqld.cc b/sql/wsrep_mysqld.cc index 93ea3bc539f..c0f48cca9cd 100644 --- a/sql/wsrep_mysqld.cc +++ b/sql/wsrep_mysqld.cc @@ -316,29 +316,31 @@ wsp::node_status local_status; */ Wsrep_schema *wsrep_schema= 0; -static void wsrep_log_cb(wsrep::log::level level, const char *msg) +static void wsrep_log_cb(wsrep::log::level level, + const char*, const char *msg) { /* Silence all wsrep related logging from lib and provider if wsrep is not enabled. */ - if (WSREP_ON) - { - switch (level) { - case wsrep::log::info: - sql_print_information("WSREP: %s", msg); - break; - case wsrep::log::warning: - sql_print_warning("WSREP: %s", msg); - break; - case wsrep::log::error: - sql_print_error("WSREP: %s", msg); + if (!WSREP_ON) return; + + switch (level) { + case wsrep::log::info: + WSREP_INFO("%s", msg); + break; + case wsrep::log::warning: + WSREP_WARN("%s", msg); + break; + case wsrep::log::error: + WSREP_ERROR("%s", msg); + break; + case wsrep::log::debug: + WSREP_DEBUG("%s", msg); + break; + case wsrep::log::unknown: + WSREP_UNKNOWN("%s", msg); break; - case wsrep::log::debug: - if (wsrep_debug) sql_print_information ("[Debug] WSREP: %s", msg); - default: - break; - } } } diff --git a/sql/wsrep_mysqld.h b/sql/wsrep_mysqld.h index b0050a2ebae..29b1c4cf1f4 100644 --- a/sql/wsrep_mysqld.h +++ b/sql/wsrep_mysqld.h @@ -251,30 +251,30 @@ void WSREP_LOG(void (*fun)(const char* fmt, ...), const char* fmt, ...); #define WSREP_INFO(...) WSREP_LOG(sql_print_information, ##__VA_ARGS__) #define WSREP_WARN(...) WSREP_LOG(sql_print_warning, ##__VA_ARGS__) #define WSREP_ERROR(...) WSREP_LOG(sql_print_error, ##__VA_ARGS__) +#define WSREP_UNKNOWN(fmt, ...) WSREP_ERROR("UNKNOWN: " fmt, ##__VA_ARGS__) #define WSREP_LOG_CONFLICT_THD(thd, role) \ - WSREP_LOG(sql_print_information, \ - "%s: \n " \ - " THD: %lu, mode: %s, state: %s, conflict: %s, seqno: %lld\n " \ - " SQL: %s", \ - role, \ - thd_get_thread_id(thd), \ - wsrep_thd_client_mode_str(thd), \ - wsrep_thd_client_state_str(thd), \ - wsrep_thd_transaction_state_str(thd), \ - wsrep_thd_trx_seqno(thd), \ - wsrep_thd_query(thd) \ + WSREP_INFO("%s: \n " \ + " THD: %lu, mode: %s, state: %s, conflict: %s, seqno: %lld\n " \ + " SQL: %s", \ + role, \ + thd_get_thread_id(thd), \ + wsrep_thd_client_mode_str(thd), \ + wsrep_thd_client_state_str(thd), \ + wsrep_thd_transaction_state_str(thd), \ + wsrep_thd_trx_seqno(thd), \ + wsrep_thd_query(thd) \ ); #define WSREP_LOG_CONFLICT(bf_thd, victim_thd, bf_abort) \ if (wsrep_debug || wsrep_log_conflicts) \ { \ - WSREP_LOG(sql_print_information, "cluster conflict due to %s for threads:", \ - (bf_abort) ? "high priority abort" : "certification failure" \ + WSREP_INFO("cluster conflict due to %s for threads:", \ + (bf_abort) ? "high priority abort" : "certification failure" \ ); \ if (bf_thd) WSREP_LOG_CONFLICT_THD(bf_thd, "Winning thread"); \ if (victim_thd) WSREP_LOG_CONFLICT_THD(victim_thd, "Victim thread"); \ - WSREP_LOG(sql_print_information, "context: %s:%d", __FILE__, __LINE__); \ + WSREP_INFO("context: %s:%d", __FILE__, __LINE__); \ } #define WSREP_PROVIDER_EXISTS \ diff --git a/sql/wsrep_server_service.cc b/sql/wsrep_server_service.cc index da021d4a7eb..cd432ab3eae 100644 --- a/sql/wsrep_server_service.cc +++ b/sql/wsrep_server_service.cc @@ -162,16 +162,19 @@ void Wsrep_server_service::log_message(enum wsrep::log::level level, switch (level) { case wsrep::log::debug: - sql_print_information("debug: %s", message); + WSREP_DEBUG("%s", message); break; case wsrep::log::info: - sql_print_information("%s", message); + WSREP_INFO("%s", message); break; case wsrep::log::warning: - sql_print_warning("%s", message); + WSREP_WARN("%s", message); break; case wsrep::log::error: - sql_print_error("%s", message); + WSREP_ERROR("%s", message); + break; + case wsrep::log::unknown: + WSREP_UNKNOWN("%s", message); break; } } diff --git a/wsrep-lib b/wsrep-lib -Subproject dcf3ce91cdb9d254ae04ecc6a2f91f46b171280 +Subproject 515ac816f98329c0227d0060cc9339c88981083 |