summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikita Malyavin <nikitamalyavin@gmail.com>2021-01-08 22:09:26 +1000
committerNikita Malyavin <nikitamalyavin@gmail.com>2021-01-08 22:09:45 +1000
commit61a362c9493df63dc588fcb71409537ae56ab9c8 (patch)
treec236c60b995c8c5b63f07eb230468262409dc774
parentcd1e5d65c6d3aab7f77860803d2d0f29bf307b4a (diff)
downloadmariadb-git-61a362c9493df63dc588fcb71409537ae56ab9c8.tar.gz
fixup MDEV-17556: fix mroonga
-rw-r--r--storage/mroonga/ha_mroonga.cpp28
-rw-r--r--storage/mroonga/lib/mrn_debug_column_access.cpp6
-rw-r--r--storage/mroonga/lib/mrn_debug_column_access.hpp4
3 files changed, 19 insertions, 19 deletions
diff --git a/storage/mroonga/ha_mroonga.cpp b/storage/mroonga/ha_mroonga.cpp
index 06ff71c1b5a..1025b70156f 100644
--- a/storage/mroonga/ha_mroonga.cpp
+++ b/storage/mroonga/ha_mroonga.cpp
@@ -5910,7 +5910,7 @@ int ha_mroonga::wrapper_write_row_index(uchar *buf)
DBUG_RETURN(0);
}
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
uint i;
uint n_keys = table->s->keys;
for (i = 0; i < n_keys; i++) {
@@ -5985,7 +5985,7 @@ int ha_mroonga::storage_write_row(uchar *buf)
DBUG_RETURN(error);
}
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
for (i = 0; i < n_columns; i++) {
Field *field = table->field[i];
@@ -6266,7 +6266,7 @@ int ha_mroonga::storage_write_row_multiple_column_indexes(uchar *buf,
int error = 0;
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
uint i;
uint n_keys = table->s->keys;
for (i = 0; i < n_keys; i++) {
@@ -6558,7 +6558,7 @@ int ha_mroonga::wrapper_update_row_index(const uchar *old_data, uchar *new_data)
DBUG_RETURN(0);
}
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
uint i;
uint n_keys = table->s->keys;
for (i = 0; i < n_keys; i++) {
@@ -6678,7 +6678,7 @@ int ha_mroonga::storage_update_row(const uchar *old_data, uchar *new_data)
grn_obj new_value;
GRN_VOID_INIT(&new_value);
{
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
generic_store_bulk(field, &new_value);
}
grn_obj casted_value;
@@ -6707,7 +6707,7 @@ int ha_mroonga::storage_update_row(const uchar *old_data, uchar *new_data)
storage_store_fields_for_prep_update(old_data, new_data, record_id);
{
mrn::Lock lock(&(share->record_mutex), have_unique_index());
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
if ((error = storage_prepare_delete_row_unique_indexes(old_data,
record_id))) {
DBUG_RETURN(error);
@@ -6732,7 +6732,7 @@ int ha_mroonga::storage_update_row(const uchar *old_data, uchar *new_data)
#endif
if (bitmap_is_set(table->write_set, field->field_index)) {
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
DBUG_PRINT("info", ("mroonga: update column %d(%d)",i,field->field_index));
if (field->is_null()) continue;
@@ -6809,7 +6809,7 @@ int ha_mroonga::storage_update_row(const uchar *old_data, uchar *new_data)
if (table->found_next_number_field &&
!table->s->next_number_keypart &&
new_data == table->record[0]) {
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
Field_num *field = (Field_num *) table->found_next_number_field;
if (field->unsigned_flag || field->val_int() > 0) {
MRN_LONG_TERM_SHARE *long_term_share = share->long_term_share;
@@ -6865,7 +6865,7 @@ int ha_mroonga::storage_update_row_index(const uchar *old_data, uchar *new_data)
my_ptrdiff_t ptr_diff = PTR_BYTE_DIFF(old_data, table->record[0]);
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
uint i;
uint n_keys = table->s->keys;
mrn_change_encoding(ctx, NULL);
@@ -7081,7 +7081,7 @@ int ha_mroonga::wrapper_delete_row_index(const uchar *buf)
DBUG_RETURN(0);
}
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
uint i;
uint n_keys = table->s->keys;
for (i = 0; i < n_keys; i++) {
@@ -7232,7 +7232,7 @@ int ha_mroonga::storage_delete_row_index(const uchar *buf)
GRN_TEXT_INIT(&key, 0);
GRN_TEXT_INIT(&encoded_key, 0);
- mrn::DebugColumnAccess debug_column_access(table, table->read_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->read_set);
uint i;
uint n_keys = table->s->keys;
mrn_change_encoding(ctx, NULL);
@@ -11420,7 +11420,7 @@ void ha_mroonga::storage_store_fields(uchar *buf, grn_id record_id)
}
}
- mrn::DebugColumnAccess debug_column_access(table, table->write_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->write_set);
DBUG_PRINT("info", ("mroonga: store column %d(%d)",i,field->field_index));
field->move_field_offset(ptr_diff);
if (strcmp(MRN_COLUMN_NAME_ID, column_name) == 0) {
@@ -11485,7 +11485,7 @@ void ha_mroonga::storage_store_fields_for_prep_update(const uchar *old_data,
)
#endif
) {
- mrn::DebugColumnAccess debug_column_access(table, table->write_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->write_set);
DBUG_PRINT("info", ("mroonga: store column %d(%d)",i,field->field_index));
grn_obj value;
GRN_OBJ_INIT(&value, GRN_BULK, 0, grn_obj_get_range(ctx, grn_columns[i]));
@@ -11521,7 +11521,7 @@ void ha_mroonga::storage_store_fields_by_index(uchar *buf)
if (KEY_N_KEY_PARTS(key_info) == 1) {
my_ptrdiff_t ptr_diff = PTR_BYTE_DIFF(buf, table->record[0]);
Field *field = key_info->key_part->field;
- mrn::DebugColumnAccess debug_column_access(table, table->write_set);
+ mrn::DebugColumnAccess debug_column_access(table, &table->write_set);
field->move_field_offset(ptr_diff);
storage_store_field(field, (const char *)key, key_length);
field->move_field_offset(-ptr_diff);
diff --git a/storage/mroonga/lib/mrn_debug_column_access.cpp b/storage/mroonga/lib/mrn_debug_column_access.cpp
index ed535f150ab..4c88d7b3e64 100644
--- a/storage/mroonga/lib/mrn_debug_column_access.cpp
+++ b/storage/mroonga/lib/mrn_debug_column_access.cpp
@@ -20,17 +20,17 @@
#include "mrn_debug_column_access.hpp"
namespace mrn {
- DebugColumnAccess::DebugColumnAccess(TABLE *table, MY_BITMAP *bitmap)
+ DebugColumnAccess::DebugColumnAccess(TABLE *table, MY_BITMAP **bitmap)
: table_(table),
bitmap_(bitmap) {
#ifndef DBUG_OFF
- map_ = dbug_tmp_use_all_columns(table_, &bitmap_);
+ map_ = dbug_tmp_use_all_columns(table_, bitmap_);
#endif
}
DebugColumnAccess::~DebugColumnAccess() {
#ifndef DBUG_OFF
- dbug_tmp_restore_column_map(&bitmap_, map_);
+ dbug_tmp_restore_column_map(bitmap_, map_);
#endif
}
}
diff --git a/storage/mroonga/lib/mrn_debug_column_access.hpp b/storage/mroonga/lib/mrn_debug_column_access.hpp
index 309db6e8460..9f85b831def 100644
--- a/storage/mroonga/lib/mrn_debug_column_access.hpp
+++ b/storage/mroonga/lib/mrn_debug_column_access.hpp
@@ -25,12 +25,12 @@
namespace mrn {
class DebugColumnAccess {
TABLE *table_;
- MY_BITMAP *bitmap_;
+ MY_BITMAP **bitmap_;
#ifndef DBUG_OFF
MY_BITMAP *map_;
#endif
public:
- DebugColumnAccess(TABLE *table, MY_BITMAP *bitmap);
+ DebugColumnAccess(TABLE *table, MY_BITMAP **bitmap);
~DebugColumnAccess();
};
}