summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOtto Kekäläinen <otto@kekalainen.net>2020-03-04 19:23:05 +0200
committerAnel Husakovic <anel@mariadb.org>2020-03-06 08:50:30 +0100
commita2da47ffb8c673797abb34f206a333935f2092ed (patch)
tree725eb89ab7efdf8d1d3587d5f2f1ba3dc8ff05e8
parent3af9c0fd1f363091b4086c9053f9cb1d0f3b317e (diff)
downloadmariadb-git-a2da47ffb8c673797abb34f206a333935f2092ed.tar.gz
Use correct reference in man page links
After the '.so' one is supposed to use the directory name, like we have correctly in all old man pages: mysql_client_test_embedded.1:.so man1/mysql_client_test.1 mysql_embedded.1:.so man1/mysql.1 mysqltest_embedded.1:.so man1/mysqltest.1 This change adds the 'man1/' component so the link has the correct format. Actually using man links is a deprecated practice and using symlinks would be better, but that can be fixed in a later commit. From https://www.debian.org/doc/debian-policy/ch-docs.html#manual-pages: > If one man page needs to be accessible via several names it is better > to use a symbolic link than the .so feature Detected via Lintian errors: E: mariadb-server-10.5: bad-so-link-within-manual-page usr/share/man/man1/mariadb-show.1.gz E: mariadb-client-10.5: bad-so-link-within-manual-page usr/share/man/man1/mariadb-binlog.1.gz E: mariadb-client-10.5: bad-so-link-within-manual-page usr/share/man/man1/mariadb-plugin.1.gz
-rw-r--r--man/CMakeLists.txt2
1 files changed, 1 insertions, 1 deletions
diff --git a/man/CMakeLists.txt b/man/CMakeLists.txt
index 1a8655c9222..48456f8154b 100644
--- a/man/CMakeLists.txt
+++ b/man/CMakeLists.txt
@@ -80,7 +80,7 @@ endmacro(MARIADB_SYMLINK_MANPAGE)
macro(MARIADB_SYMLINK_MANPAGE_CREATE mysqlname index mannr dir comp)
LIST(GET MARIADB_SYMLINK_TOS ${index} _mariadbname)
SET(dest "${CMAKE_CURRENT_BINARY_DIR}/${_mariadbname}.${mannr}")
- FILE(WRITE ${dest} ".so ${mysqlname}.${mannr}")
+ FILE(WRITE ${dest} ".so ${dir}/${mysqlname}.${mannr}")
INSTALL(FILES ${dest} DESTINATION ${INSTALL_MANDIR}/${dir} COMPONENT ${comp})
endmacro(MARIADB_SYMLINK_MANPAGE_CREATE)