summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Lindström <jan.lindstrom@mariadb.com>2017-01-31 15:42:52 +0200
committerJan Lindström <jan.lindstrom@mariadb.com>2017-01-31 15:42:52 +0200
commit17cc6198479d83bd4f88e9fff197b0b342dca5d9 (patch)
tree67e2bd17cd5ce42a2a47dcb24bba9102612b90a0
parent41997d148dc1999c202f14e82e172c1ff57c7ead (diff)
downloadmariadb-git-17cc6198479d83bd4f88e9fff197b0b342dca5d9.tar.gz
MDEV-11671: Duplicated [NOTE] output for changed innodb_page_size
Remove duplicated output and change output level to info.
-rw-r--r--storage/innobase/handler/ha_innodb.cc32
-rw-r--r--storage/xtradb/handler/ha_innodb.cc33
2 files changed, 26 insertions, 39 deletions
diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc
index 33eb352c42f..350438e0495 100644
--- a/storage/innobase/handler/ha_innodb.cc
+++ b/storage/innobase/handler/ha_innodb.cc
@@ -3448,22 +3448,16 @@ innobase_init(
}
}
- if (UNIV_PAGE_SIZE != UNIV_PAGE_SIZE_DEF) {
+ /* The buffer pool needs to be able to accommodate enough many
+ pages, even for larger pages */
+ if (UNIV_PAGE_SIZE > UNIV_PAGE_SIZE_DEF
+ && innobase_buffer_pool_size < (24 * 1024 * 1024)) {
ib_logf(IB_LOG_LEVEL_INFO,
- "innodb_page_size has been "
- "changed from default value %d to %ld.",
- UNIV_PAGE_SIZE_DEF, UNIV_PAGE_SIZE);
-
- /* There is hang on buffer pool when trying to get a new
- page if buffer pool size is too small for large page sizes */
- if (UNIV_PAGE_SIZE > UNIV_PAGE_SIZE_DEF
- && innobase_buffer_pool_size < (24 * 1024 * 1024)) {
- ib_logf(IB_LOG_LEVEL_ERROR,
- "innodb_page_size=%lu requires "
- "innodb_buffer_pool_size > 24M current %lld",
- UNIV_PAGE_SIZE, innobase_buffer_pool_size);
- goto error;
- }
+ "innodb_page_size= " ULINTPF " requires "
+ "innodb_buffer_pool_size > 24M current %lld. ",
+ UNIV_PAGE_SIZE,
+ innobase_buffer_pool_size);
+ goto error;
}
#ifndef HAVE_LZ4
@@ -3764,11 +3758,11 @@ innobase_change_buffering_inited_ok:
srv_page_size);
goto mem_free_and_error;
}
+
if (UNIV_PAGE_SIZE_DEF != srv_page_size) {
- ut_print_timestamp(stderr);
- fprintf(stderr,
- " InnoDB: innodb-page-size has been changed"
- " from the default value %d to %lu.\n",
+ ib_logf(IB_LOG_LEVEL_INFO,
+ " innodb-page-size has been changed"
+ " from the default value %d to " ULINTPF ".",
UNIV_PAGE_SIZE_DEF, srv_page_size);
}
diff --git a/storage/xtradb/handler/ha_innodb.cc b/storage/xtradb/handler/ha_innodb.cc
index e9d42097fd0..bef54a910e6 100644
--- a/storage/xtradb/handler/ha_innodb.cc
+++ b/storage/xtradb/handler/ha_innodb.cc
@@ -3865,23 +3865,16 @@ innobase_init(
srv_log_block_size = 512;
}
- if (UNIV_PAGE_SIZE != UNIV_PAGE_SIZE_DEF) {
+ /* The buffer pool needs to be able to accommodate enough many
+ pages, even for larger pages */
+ if (UNIV_PAGE_SIZE > UNIV_PAGE_SIZE_DEF
+ && innobase_buffer_pool_size < (24 * 1024 * 1024)) {
ib_logf(IB_LOG_LEVEL_INFO,
- "innodb_page_size has been "
- "changed from default value %d to %ld.",
- UNIV_PAGE_SIZE_DEF, UNIV_PAGE_SIZE);
-
- /* There is hang on buffer pool when trying to get a new
- page if buffer pool size is too small for large page sizes */
- if (UNIV_PAGE_SIZE > UNIV_PAGE_SIZE_DEF
- && innobase_buffer_pool_size < (24 * 1024 * 1024)) {
- ib_logf(IB_LOG_LEVEL_ERROR,
- "innodb_page_size=%lu requires "
- "innodb_buffer_pool_size > 24M current %lld",
- UNIV_PAGE_SIZE, innobase_buffer_pool_size);
-
- goto error;
- }
+ "innodb_page_size= " ULINTPF " requires "
+ "innodb_buffer_pool_size > 24M current %lld. ",
+ UNIV_PAGE_SIZE,
+ innobase_buffer_pool_size);
+ goto error;
}
ut_ad (srv_log_block_size >= OS_MIN_LOG_BLOCK_SIZE);
@@ -4204,11 +4197,11 @@ innobase_change_buffering_inited_ok:
srv_page_size);
goto mem_free_and_error;
}
+
if (UNIV_PAGE_SIZE_DEF != srv_page_size) {
- ut_print_timestamp(stderr);
- fprintf(stderr,
- " InnoDB: innodb-page-size has been changed"
- " from the default value %d to %lu.\n",
+ ib_logf(IB_LOG_LEVEL_INFO,
+ " innodb-page-size has been changed"
+ " from the default value %d to " ULINTPF " .",
UNIV_PAGE_SIZE_DEF, srv_page_size);
}