summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorunknown <tsmith@build.mysql.com>2004-05-11 14:44:25 +0200
committerunknown <tsmith@build.mysql.com>2004-05-11 14:44:25 +0200
commit7b4cbde8edeb461ddacdc4d06d33fb8705380f40 (patch)
treed8be36cfc6d6ec5a6c535421185ce63634f267fe
parent5e96b1c52a92bffb0b5d00a4b0c2e08093d580e3 (diff)
parentd5c2e2b2d34e90250b3f24071ab718684e58f0b1 (diff)
downloadmariadb-git-7b4cbde8edeb461ddacdc4d06d33fb8705380f40.tar.gz
Merge build:/home/bk/mysql-4.1
into build.mysql.com:/users/tsmith/m/41/mysql-4.1
-rw-r--r--BitKeeper/etc/logging_ok1
-rw-r--r--mysql-test/r/ctype_recoding.result7
-rw-r--r--mysql-test/t/ctype_recoding.test8
-rw-r--r--sql/item_cmpfunc.cc1
4 files changed, 16 insertions, 1 deletions
diff --git a/BitKeeper/etc/logging_ok b/BitKeeper/etc/logging_ok
index a8379b3d338..b56e38f3d9c 100644
--- a/BitKeeper/etc/logging_ok
+++ b/BitKeeper/etc/logging_ok
@@ -163,6 +163,7 @@ tonu@hundin.mysql.fi
tonu@volk.internalnet
tonu@x153.internalnet
tonu@x3.internalnet
+tsmith@build.mysql.com
ulli@morbus.(none)
venu@hundin.mysql.fi
venu@myvenu.com
diff --git a/mysql-test/r/ctype_recoding.result b/mysql-test/r/ctype_recoding.result
index 7209c86bb31..ed59de87395 100644
--- a/mysql-test/r/ctype_recoding.result
+++ b/mysql-test/r/ctype_recoding.result
@@ -82,6 +82,13 @@ Field Type Null Key Default Extra
SET CHARACTER SET koi8r;
DROP TABLE таблица;
SET CHARACTER SET default;
+SET NAMES UTF8;
+CREATE TABLE t1 (t text) DEFAULT CHARSET UTF8;
+INSERT INTO t1 (t) VALUES ('x');
+SELECT 1 FROM t1 WHERE CONCAT(_latin1'x') = t;
+1
+1
+DROP TABLE t1;
SET CHARACTER SET koi8r;
CREATE DATABASE тест;
USE тест;
diff --git a/mysql-test/t/ctype_recoding.test b/mysql-test/t/ctype_recoding.test
index 40349da8aa9..8ac22e89c2d 100644
--- a/mysql-test/t/ctype_recoding.test
+++ b/mysql-test/t/ctype_recoding.test
@@ -56,6 +56,13 @@ SET CHARACTER SET koi8r;
DROP TABLE таблица;
SET CHARACTER SET default;
+# Test for Item_func_conv_charset::fix_fields (bug #3704)
+SET NAMES UTF8;
+CREATE TABLE t1 (t text) DEFAULT CHARSET UTF8;
+INSERT INTO t1 (t) VALUES ('x');
+SELECT 1 FROM t1 WHERE CONCAT(_latin1'x') = t;
+DROP TABLE t1;
+
SET CHARACTER SET koi8r;
CREATE DATABASE тест;
USE тест;
@@ -71,4 +78,3 @@ SET NAMES koi8r;
SELECT hex('тест');
SET character_set_connection=cp1251;
SELECT hex('тест');
-
diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc
index afbf0b7163e..446d72ac143 100644
--- a/sql/item_cmpfunc.cc
+++ b/sql/item_cmpfunc.cc
@@ -221,6 +221,7 @@ void Item_bool_func2::fix_length_and_dec()
{
conv= new Item_func_conv_charset(args[weak],args[strong]->collation.collation);
conv->collation.set(args[weak]->collation.derivation);
+ conv->fix_fields(current_thd, 0, &conv);
}
args[weak]= conv ? conv : args[weak];
}