summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSachin Setiya <sachinsetia1001@gmail.com>2016-12-14 15:58:14 +0530
committerSachin Setiya <sachinsetia1001@gmail.com>2016-12-14 15:58:14 +0530
commit95422c445db7db60fca688711d98955e59e009e2 (patch)
treec6bf64f9e2f2b6561964067b41e9f9a472e42809
parent313a14f79e6de43acd5c2ceffbcc01af2506d800 (diff)
downloadmariadb-git-95422c445db7db60fca688711d98955e59e009e2.tar.gz
Revert " MDEV-11016 wsrep_node_is_ready() check is too strict"
This reverts commit 72fd15f7c31aa3e3705ae1b005a3247a985c5bb3. # Conflicts: # mysql-test/suite/galera/r/galera_var_dirty_reads.result # mysql-test/suite/galera/t/galera_var_dirty_reads.test
-rw-r--r--mysql-test/suite/galera/r/galera_var_dirty_reads.result16
-rw-r--r--mysql-test/suite/galera/t/galera_var_dirty_reads.test13
-rw-r--r--sql/sql_parse.cc4
3 files changed, 0 insertions, 33 deletions
diff --git a/mysql-test/suite/galera/r/galera_var_dirty_reads.result b/mysql-test/suite/galera/r/galera_var_dirty_reads.result
index c0ffb2d4860..6d703c8cf95 100644
--- a/mysql-test/suite/galera/r/galera_var_dirty_reads.result
+++ b/mysql-test/suite/galera/r/galera_var_dirty_reads.result
@@ -18,22 +18,6 @@ SET @@session.wsrep_dirty_reads=ON;
SELECT * FROM t1;
i
1
-#
-# MDEV-11016: wsrep_node_is_ready() check is too strict
-#
-SET @@session.wsrep_dirty_reads=OFF;
-SELECT 2;
-2
-2
-SELECT 2+2 from DUAL;
-2+2
-4
-SET @VAR=1;
-SELECT @VAR;
-@VAR
-1
-SELECT @@max_allowed_packet;
-SELECT SYSDATE() from DUAL;
SELECT * FROM t1;
i
1
diff --git a/mysql-test/suite/galera/t/galera_var_dirty_reads.test b/mysql-test/suite/galera/t/galera_var_dirty_reads.test
index 48fbe37139c..9eea8efdaf3 100644
--- a/mysql-test/suite/galera/t/galera_var_dirty_reads.test
+++ b/mysql-test/suite/galera/t/galera_var_dirty_reads.test
@@ -39,19 +39,6 @@ SET @@session.wsrep_dirty_reads=ON;
SELECT * FROM t1;
---echo #
---echo # MDEV-11016: wsrep_node_is_ready() check is too strict
---echo #
-SET @@session.wsrep_dirty_reads=OFF;
-SELECT 2;
-SELECT 2+2 from DUAL;
-SET @VAR=1;
-SELECT @VAR;
---disable_result_log
-SELECT @@max_allowed_packet;
-SELECT SYSDATE() from DUAL;
---enable_result_log
-
--disable_query_log
--eval SET @@global.wsrep_cluster_address = '$wsrep_cluster_address_saved'
--enable_query_log
diff --git a/sql/sql_parse.cc b/sql/sql_parse.cc
index eb4f7141918..48addaab143 100644
--- a/sql/sql_parse.cc
+++ b/sql/sql_parse.cc
@@ -2388,15 +2388,11 @@ mysql_execute_command(THD *thd)
/*
Bail out if DB snapshot has not been installed. We however,
allow SET and SHOW queries.
- SHOW and SELECT queries (only if wsrep_dirty_reads is set or when it
- does not access any table).
*/
if (thd->variables.wsrep_on && !thd->wsrep_applier && !wsrep_ready &&
lex->sql_command != SQLCOM_SET_OPTION &&
!(thd->variables.wsrep_dirty_reads &&
lex->sql_command == SQLCOM_SELECT) &&
- !(lex->sql_command == SQLCOM_SELECT &&
- !all_tables) &&
!wsrep_is_show_query(lex->sql_command))
{
#if DIRTY_HACK