summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSachin Agarwal <sachin.z.agarwal@oracle.com>2017-12-18 18:40:08 +0530
committerMarko Mäkelä <marko.makela@mariadb.com>2018-05-11 19:10:32 +0300
commitb7e333f98a711931cbcbb444302fcbddcefb6f10 (patch)
treee8d903f174243132fb7768362c71956856c0462b
parent671a37f60e6663a175368b134574c0274964589b (diff)
downloadmariadb-git-b7e333f98a711931cbcbb444302fcbddcefb6f10.tar.gz
Bug #26805833 INNODB COMPLAINS OF SYNTAX ERROR, BUT DOES NOT SAY WHICH OPTION
Problem: when incorrect value is assigned to innodb_data_file_path or innodb_temp_data_file_path parameter, Innodb returns error and logs error message in mysqlds.err file but there is no information in error message about the parameter which causes Innodb initialization is failed. Fix: Added error message with parameter name and value, which causes Innodb initialization is failed. Reviewed by: Jimmy <Jimmy.Yang@oracle.com> RB: 18206
-rw-r--r--mysql-test/suite/innodb/t/temporary_table.test1
-rw-r--r--storage/innobase/handler/ha_innodb.cc4
2 files changed, 5 insertions, 0 deletions
diff --git a/mysql-test/suite/innodb/t/temporary_table.test b/mysql-test/suite/innodb/t/temporary_table.test
index 9a640657c4d..db87367dbb9 100644
--- a/mysql-test/suite/innodb/t/temporary_table.test
+++ b/mysql-test/suite/innodb/t/temporary_table.test
@@ -21,6 +21,7 @@ call mtr.add_suppression("InnoDB: Plugin initialization aborted");
call mtr.add_suppression("innodb_temporary and innodb_system file names seem to be the same");
call mtr.add_suppression("Could not create the shared innodb_temporary");
call mtr.add_suppression("InnoDB: syntax error in file path");
+call mtr.add_suppression("InnoDB: Unable to parse innodb_temp_data_file_path=");
--enable_query_log
let $MYSQL_TMP_DIR = `select @@tmpdir`;
diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc
index 51a8e3abaf0..b74c886c692 100644
--- a/storage/innobase/handler/ha_innodb.cc
+++ b/storage/innobase/handler/ha_innodb.cc
@@ -3932,6 +3932,8 @@ innobase_init(
/* Supports raw devices */
if (!srv_sys_space.parse_params(innobase_data_file_path, true)) {
+ ib::error() << "Unable to parse innodb_data_file_path="
+ << innobase_data_file_path;
DBUG_RETURN(innobase_init_abort());
}
@@ -3950,6 +3952,8 @@ innobase_init(
srv_tmp_space.set_flags(FSP_FLAGS_PAGE_SSIZE());
if (!srv_tmp_space.parse_params(innobase_temp_data_file_path, false)) {
+ ib::error() << "Unable to parse innodb_temp_data_file_path="
+ << innobase_temp_data_file_path;
DBUG_RETURN(innobase_init_abort());
}