summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorguilhem@mysql.com <>2003-06-22 14:10:46 +0200
committerguilhem@mysql.com <>2003-06-22 14:10:46 +0200
commit9990ce576b666980904ae8202b079bdd8fdd00ba (patch)
tree22f5ae4e0d12cff2b9c8e8a251b831e532a52713
parent04e5a6baa9e9a33539585456dce316e8e2fd1227 (diff)
downloadmariadb-git-9990ce576b666980904ae8202b079bdd8fdd00ba.tar.gz
Fixed cleanup_load_tmpdir() which deleted nothing.
-rw-r--r--sql/log_event.cc9
-rw-r--r--sql/sql_repl.cc9
2 files changed, 12 insertions, 6 deletions
diff --git a/sql/log_event.cc b/sql/log_event.cc
index ff968babcf0..727b2052969 100644
--- a/sql/log_event.cc
+++ b/sql/log_event.cc
@@ -168,12 +168,15 @@ static void cleanup_load_tmpdir()
uint i;
if (!(dirp=my_dir(slave_load_tmpdir,MYF(MY_WME))))
return;
-
+ char fname[FN_REFLEN];
for (i=0 ; i < (uint)dirp->number_off_files; i++)
{
file=dirp->dir_entry+i;
if (is_prefix(file->name,"SQL_LOAD-"))
- my_delete(file->name, MYF(0));
+ {
+ fn_format(fname,file->name,slave_load_tmpdir,"",0);
+ my_delete(fname, MYF(0));
+ }
}
my_dirend(dirp);
@@ -813,7 +816,7 @@ Rotate_log_event::Rotate_log_event(const char* buf, int event_len,
int Rotate_log_event::write_data(IO_CACHE* file)
{
char buf[ROTATE_HEADER_LEN];
- int8store(buf, pos + R_POS_OFFSET);
+ int8store(buf + R_POS_OFFSET, pos);
return (my_b_safe_write(file, (byte*)buf, ROTATE_HEADER_LEN) ||
my_b_safe_write(file, (byte*)new_log_ident, (uint) ident_len));
}
diff --git a/sql/sql_repl.cc b/sql/sql_repl.cc
index a3cfe442b0f..d0ed1a19d96 100644
--- a/sql/sql_repl.cc
+++ b/sql/sql_repl.cc
@@ -68,9 +68,12 @@ static int fake_rotate_event(NET* net, String* packet, char* log_file_name,
int4store(header + LOG_POS_OFFSET, 0);
packet->append(header, sizeof(header));
- /* We need to split the next statement because of problem with cxx */
- int4store(buf,position);
- int4store(buf+4,0);
+ /*
+ An old comment said talked about a need for splitting the int8store below
+ into 2 int4store because of a problem with cxx; I can't understand that as
+ we already use int8store in Rotatel_log_event::write_data().
+ */
+ int8store(buf+R_POS_OFFSET,position);
packet->append(buf, ROTATE_HEADER_LEN);
packet->append(p,ident_len);
if (my_net_write(net, (char*)packet->ptr(), packet->length()))