diff options
| author | Oleksandr Byelkin <sanja@mariadb.com> | 2017-04-19 14:30:52 +0200 |
|---|---|---|
| committer | Oleksandr Byelkin <sanja@mariadb.com> | 2017-04-19 14:30:52 +0200 |
| commit | d185f1d68bb1f37bea10d8ac6188e5a04faf4522 (patch) | |
| tree | 30344586c13f1a23c343466d3645346bc83a2c7b /cmake/cpack_rpm.cmake | |
| parent | d53b541389a02c36448a4ebe21f2a7de7d53f9b3 (diff) | |
| download | mariadb-git-d185f1d68bb1f37bea10d8ac6188e5a04faf4522.tar.gz | |
Fix use of `require` in mysql-test-run.
The motivation for this is that Perl is moving towards not having
current directory ./ in @INC by default. This is causing
mysql-test-run.pl to fail in latest Debian Unstable:
https://lists.debian.org/debian-devel-announce/2016/08/msg00013.html
However, we have `use "lib"`, there is no need for current directory
in @INC, except for a gross hack. In mtr_cases.pm, there is a
`require "mtr_misc.pl"`, which hides mtr_misc.pl away in mtr_cases
namespace. And things only work because mysql-test-run.pl loads it
with a different name, `require "lib/mtr_misc.pl"`! (Perl will
`require` only once for each unique filename).
Fix this by only using `require` in main program, and referencing
functions with :: scope from other namespaces. For multi-use in
different namespaces, proper `use` modules should be used.
Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
Diffstat (limited to 'cmake/cpack_rpm.cmake')
0 files changed, 0 insertions, 0 deletions