summaryrefslogtreecommitdiff
path: root/cmd-line-utils
diff options
context:
space:
mode:
authorMarc Alff <marc.alff@sun.com>2008-08-12 17:05:19 -0600
committerMarc Alff <marc.alff@sun.com>2008-08-12 17:05:19 -0600
commit7ea370d2a2360a1ee6a3205fd2b0f188309e9885 (patch)
treee6dc3e5fc524427e1ccb935bb737cd55e82d4a77 /cmd-line-utils
parent7f228cf20ea057a5d677d3546c6b29742db386a7 (diff)
downloadmariadb-git-7ea370d2a2360a1ee6a3205fd2b0f188309e9885.tar.gz
Bug#38296 (low memory crash with many conditions in a query)
This fix is for 5.1 only : back porting the 6.0 patch manually The parser code in sql/sql_yacc.yy needs to be more robust to out of memory conditions, so that when parsing a query fails due to OOM, the thread gracefully returns an error. Before this fix, a new/alloc returning NULL could: - cause a crash, if dereferencing the NULL pointer, - produce a corrupted parsed tree, containing NULL nodes, - alter the semantic of a query, by silently dropping token values or nodes With this fix: - C++ constructors are *not* executed with a NULL "this" pointer when operator new fails. This is achieved by declaring "operator new" with a "throw ()" clause, so that a failed new gracefully returns NULL on OOM conditions. - calls to new/alloc are tested for a NULL result, - The thread diagnostic area is set to an error status when OOM occurs. This ensures that a request failing in the server properly returns an ER_OUT_OF_RESOURCES error to the client. - OOM conditions cause the parser to stop immediately (MYSQL_YYABORT). This prevents causing further crashes when using a partially built parsed tree in further rules in the parser. No test scripts are provided, since automating OOM failures is not instrumented in the server. Tested under the debugger, to verify that an error in alloc_root cause the thread to returns gracefully all the way to the client application, with an ER_OUT_OF_RESOURCES error.
Diffstat (limited to 'cmd-line-utils')
0 files changed, 0 insertions, 0 deletions