diff options
| author | unknown <jperkin@production.mysql.com> | 2007-08-20 16:14:35 +0200 |
|---|---|---|
| committer | unknown <jperkin@production.mysql.com> | 2007-08-20 16:14:35 +0200 |
| commit | dacab8d91c303cee3a8ff2b99ef894800323cdad (patch) | |
| tree | c59aec2aeb317f47c2727c20d01431b4591f42cf /config/ac-macros/misc.m4 | |
| parent | 46d5ebb120f17e9e2ad1490d1e572a3b0cd145bf (diff) | |
| download | mariadb-git-dacab8d91c303cee3a8ff2b99ef894800323cdad.tar.gz | |
Fix bug#27520. For some unknown reason, libtool.m4 attempts
to find "ar" but if it cannot be found sets AR=false. This
leads to confusing failures during the build rather than at
configure time.
We have our own checks for ar, but as AR was already set
earlier by the libtool tests they were never exectuted.
Therefore, update the tests so that we catch any libtool
failures, and run AC_CHECK_PROG explicitly to ensure that we
see sensible output from configure prior to any potential
failure.
config/ac-macros/misc.m4:
AC_CHECK_PROG does nothing if the first argument (variable) is
already set, so remove redundant check for the empty string.
This also ensures that a 'checking for ar' message is printed
prior to any failure, which is far less confusing.
Diffstat (limited to 'config/ac-macros/misc.m4')
| -rw-r--r-- | config/ac-macros/misc.m4 | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/config/ac-macros/misc.m4 b/config/ac-macros/misc.m4 index 60c0469e449..9c7b9aeb171 100644 --- a/config/ac-macros/misc.m4 +++ b/config/ac-macros/misc.m4 @@ -773,11 +773,8 @@ case $CXX_VERSION in ARFLAGS="-xar -o" ;; *) - if test -z "$AR" - then - AC_CHECK_PROG([AR], [ar], [ar]) - fi - if test -z "$AR" + AC_CHECK_PROG([AR], [ar], [ar]) + if test -z "$AR" || test "$AR" = "false" then AC_MSG_ERROR([You need ar to build the library]) fi |