fixes #5423 fixes #5424 fixes #5503 fixes #5225 fsync always succeeds and returns void, no more ft panic or logger panic, no more impossible error paths

git-svn-id: file:///svn/toku/tokudb@48076 c7de825b-a66e-492c-adef-691d508d4ae1

1 files changed, 6 insertions, 7 deletions

diff --git a/ft/tests/ftloader-test-writer.cc b/ft/tests/ftloader-test-writer.cc
index bd4b024a46f..e29106e8aea 100644
--- a/ft/tests/ftloader-test-writer.cc
+++ b/ft/tests/ftloader-test-writer.cc
@@ -43,13 +43,12 @@ static void verify_dbfile(int n, const char *name) {
     int r;
 
     CACHETABLE ct;
-    r = toku_create_cachetable(&ct, 0, ZERO_LSN, NULL_LOGGER); assert(r==0);
+    toku_cachetable_create(&ct, 0, ZERO_LSN, NULL_LOGGER);
 
     TOKUTXN const null_txn = NULL;
     FT_HANDLE t = NULL;
-    r = toku_ft_handle_create(&t); assert(r == 0);
-    r = toku_ft_set_bt_compare(t, compare_ints);
-    assert(r==0);
+    toku_ft_handle_create(&t);
+    toku_ft_set_bt_compare(t, compare_ints);
     r = toku_ft_handle_open(t, name, 0, 0, ct, null_txn); assert(r==0);
 
     if (verbose) traceit("Verifying brt internals");
@@ -76,14 +75,14 @@ static void verify_dbfile(int n, const char *name) {
 
     assert(i == n);
 
-    r = toku_ft_cursor_close(cursor); assert(r == 0);
+    toku_ft_cursor_close(cursor);
 
     struct ftstat64_s s;
-    r = toku_ft_handle_stat64(t, NULL, &s); assert(r == 0);
+    toku_ft_handle_stat64(t, NULL, &s);
     assert(s.nkeys == (uint64_t)n && s.ndata == (uint64_t)n && s.dsize == userdata);
 
     r = toku_close_ft_handle_nolsn(t, 0); assert(r==0);
-    r = toku_cachetable_close(&ct);assert(r==0);
+    toku_cachetable_close(&ct);
     if (verbose) traceit("verify done");
 }