diff options
author | Monty <monty@mariadb.org> | 2021-02-05 14:57:46 +0200 |
---|---|---|
committer | Monty <monty@mariadb.org> | 2021-02-08 12:16:29 +0200 |
commit | 5d6ad2ad66a677b67f2377d7665d6c140dd93323 (patch) | |
tree | 85a54b1a982beb401f04d5bcb621a1166b33b653 /include/my_getopt.h | |
parent | e30a3048dacca5180e8d7b2934d0b1fe44b4f383 (diff) | |
download | mariadb-git-5d6ad2ad66a677b67f2377d7665d6c140dd93323.tar.gz |
Added 'const' to arguments in get_one_option and find_typeset()
One should not change the program arguments!
This change also reduces warnings from the icc compiler.
Almost all changes are just syntax changes (adding const to
'get_one_option function' declarations).
Other changes:
- Added a few cast of 'argument' from 'const char*' to 'char *'. This
was mainly in calls to 'external' functions we don't have control of.
- Ensure that all reset of 'password command line argument' are similar.
(In almost all cases it was just adding a comment and a cast)
- In mysqlbinlog.cc and mysqld.cc there was a few cases that changed
the command line argument. These places where changed to instead allocate
the option in a MEM_ROOT to avoid changing the argument. Some of this
code was changed to ensure that different programs did parsing the
same way. Added a test case for the changes in mysqlbinlog.cc
- Changed a few variables that took their value from command line options
from 'char *' to 'const char *'.
Diffstat (limited to 'include/my_getopt.h')
-rw-r--r-- | include/my_getopt.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/my_getopt.h b/include/my_getopt.h index 642fb344d92..ffff706e015 100644 --- a/include/my_getopt.h +++ b/include/my_getopt.h @@ -89,7 +89,7 @@ struct my_option void *app_type; /**< To be used by an application */ }; -typedef my_bool (*my_get_one_option)(const struct my_option *, char *, const char *); +typedef my_bool (*my_get_one_option)(const struct my_option *, const char *, const char *); /** Used to retrieve a reference to the object (variable) that holds the value |