diff options
author | unknown <guilhem@mysql.com> | 2004-06-15 11:35:23 +0200 |
---|---|---|
committer | unknown <guilhem@mysql.com> | 2004-06-15 11:35:23 +0200 |
commit | aba49a6c0bf31b7b9c481058be660661797c8e77 (patch) | |
tree | 5975f12541afcd6e853432cf20d0f88672d428f7 /include/mysql.h | |
parent | 10ce930c531ad7adee2cb1990f611abd0a731434 (diff) | |
download | mariadb-git-aba49a6c0bf31b7b9c481058be660661797c8e77.tar.gz |
API change: mysql_shutdown() now needs a 2nd parameter, the shutdown level.
Server will however still accept shutdown without specified level; so that old
mysqladmin can still shut server down.
I would like your comments on the names of shutdown level which I chose. You
are welcome to propose better names. Please however check WL#709 before.
Reason for the names I propose is to be accurate, thus leaving possibility
for other levels which we may imagine in the future; that's why I have rejected
names like "fast", "smart", "graceful" so far. My position is that WAIT_ALL_BUFFERS
or WAIT_CRITICAL_BUFFERS say what the shutdown does, whereas for "smart", "fast" you
need to remember what it does.
This should be pushed in 4.1.3 but only after your comments.
client/mysqladmin.c:
2nd parameter for mysql_shutdown()
include/mysql.h:
2nd paramater for mysql_shutdown()
include/mysql_com.h:
4 types of shutdown
libmysql/libmysql.c:
passing the requested shutdown level
sql/sql_parse.cc:
check for the shutdown level in dispatch_command(). Though its value is ignored for now.
tools/mysqlmanager.c:
2nd parameter to mysql_shutdown
Diffstat (limited to 'include/mysql.h')
-rw-r--r-- | include/mysql.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/mysql.h b/include/mysql.h index 71bff833d59..57c04f32dc8 100644 --- a/include/mysql.h +++ b/include/mysql.h @@ -453,7 +453,9 @@ int STDCALL mysql_add_slave(MYSQL* mysql, const char* host, const char* user, const char* passwd); -int STDCALL mysql_shutdown(MYSQL *mysql); +int STDCALL mysql_shutdown(MYSQL *mysql, + enum enum_shutdown_level + shutdown_level); int STDCALL mysql_dump_debug_info(MYSQL *mysql); int STDCALL mysql_refresh(MYSQL *mysql, unsigned int refresh_options); |