diff options
| author | unknown <dlenev@dlenev.mshome> | 2004-02-10 16:58:20 +0300 |
|---|---|---|
| committer | unknown <dlenev@dlenev.mshome> | 2004-02-10 16:58:20 +0300 |
| commit | 94f215cbe1d75b5eaf88f0e022a53918a36609a5 (patch) | |
| tree | 72d437a30389a2f7d1f385753fa89f6130dfe0f9 /include | |
| parent | 63f15064a48e4a3fbd5a15bda39d70ee5254a6ac (diff) | |
| download | mariadb-git-94f215cbe1d75b5eaf88f0e022a53918a36609a5.tar.gz | |
Fixed bug #2248 "mysql_fetch without prior mysql_execute hangs"
Done clean-up in prep stmt API functions:
1) Removed some checks that were performed only in debug version
were making debug version more tolerable to user errors than
production (and thus caused problems for example masking some
bugs).
2) Also removed some other checks to make prep stmt API
consistent with the rest of C API (this also in line with
general politics - make checks in only those places where
errors are very common and hard to spot).
include/mysql.h:
Removed CHECK_EXTRA_ARGUMENTS define since it is no longer used
anywhere.
libmysql/libmysql.c:
Added check that will cause mysql_fetch() to bark then it is
used without calling mysql_execute() before.
Removed checks that were performed only in debug version and
caused problems since they were making debug version more
tolerable to user errors than production. Also removed some
other checks to make prep stmt API consistent in this regard
with the rest of C API (this also in line with general politics -
make checks in only those places where errors are very common
and hard to spot).
tests/client_test.c:
Updated tests to reflect removal of some checks in prep stmt API.
Removed lines that caused bug #2473 to pop up, should be added
as separate test with the fix for this bug.
Added test for bug#2248 "mysql_fetch without prior mysql_execute
hangs"
Diffstat (limited to 'include')
| -rw-r--r-- | include/mysql.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/include/mysql.h b/include/mysql.h index d1b467f9649..ebf3928ce9c 100644 --- a/include/mysql.h +++ b/include/mysql.h @@ -57,9 +57,6 @@ typedef int my_socket; #include "mysql_com.h" #include "mysql_version.h" #include "typelib.h" -#ifndef DBUG_OFF -#define CHECK_EXTRA_ARGUMENTS -#endif #include "my_list.h" /* for LISTs used in 'MYSQL' and 'MYSQL_STMT' */ |