Added xml patch to mysqldump.

Made innodb to compile more cleanly with debugging options
enabled. Fixed a few bugs and found a few possible bugs, which
I hope Heikki will check. Comments needs to be fixed too. Some
while() functions should be changed to do ... until for documenting
purposes, because some of them must and will be processed at least
once, or a variable would be used uninitialized.

Regards,
Jani


client/mysqldump.c:
  Added xml output. Patch originally from Gary Huntress, but needed
  a some clean up.
innobase/btr/btr0btr.c:
  cleaner compiling
innobase/btr/btr0cur.c:
  cleaner compiling
innobase/btr/btr0sea.c:
  cleaner compiling / found a bug ??
innobase/buf/buf0buf.c:
  Fixed a bug.
innobase/buf/buf0lru.c:
  Fixed a bug.
innobase/data/data0data.c:
  cleaner compiling
innobase/dict/dict0boot.c:
  cleaner compiling
innobase/dict/dict0crea.c:
  cleaner compiling
innobase/dict/dict0dict.c:
  cleaner compiling
innobase/dict/dict0load.c:
  cleaner compiling
innobase/eval/eval0eval.c:
  cleaner compiling / found a bug ??
innobase/fil/fil0fil.c:
  cleaner compiling
innobase/fsp/fsp0fsp.c:
  cleaner compiling
innobase/ibuf/ibuf0ibuf.c:
  cleaner compiling
innobase/include/btr0btr.ic:
  cleaner compiling
innobase/include/buf0buf.ic:
  cleaner compiling
innobase/include/dict0dict.ic:
  cleaner compiling
innobase/include/ha0ha.ic:
  cleaner compiling
innobase/include/row0mysql.ic:
  cleaner compiling
innobase/include/row0vers.ic:
  cleaner compiling
innobase/include/sync0rw.ic:
  cleaner compiling
innobase/lock/lock0lock.c:
  cleaner compiling
innobase/mem/mem0dbg.c:
  cleaner compiling
innobase/mtr/mtr0mtr.c:
  cleaner compiling
innobase/odbc/odbc0odbc.c:
  cleaner compiling
innobase/os/os0thread.c:
  cleaner compiling
innobase/page/page0cur.c:
  cleaner compiling. while() should be changed to do ... until
  for documenting purposes.
innobase/page/page0page.c:
  cleaner compiling
innobase/pars/pars0opt.c:
  cleaner compiling. while() should be changed to do ... until,
  because it will and must be processed at least once (for documenting
  purposes)
innobase/pars/pars0pars.c:
  cleaner compiling
innobase/que/que0que.c:
  cleaner compiling
innobase/rem/rem0cmp.c:
  cleaner compiling
innobase/rem/rem0rec.c:
  cleaner compiling
innobase/row/row0ins.c:
  cleaner compiling
innobase/row/row0mysql.c:
  cleaner compiling
innobase/row/row0purge.c:
  cleaner compiling
innobase/row/row0sel.c:
  cleaner compiling
innobase/row/row0uins.c:
  cleaner compiling
innobase/row/row0umod.c:
  cleaner compiling
innobase/row/row0upd.c:
  cleaner compiling
innobase/srv/srv0srv.c:
  cleaner compiling
innobase/srv/srv0start.c:
  cleaner compiling
innobase/sync/sync0arr.c:
  cleaner compiling
innobase/sync/sync0rw.c:
  cleaner compiling
innobase/sync/sync0sync.c:
  cleaner compiling
innobase/trx/trx0purge.c:
  cleaner compiling. in theory this could also be a bug, although
  probably not. But the logic needs to be checked, it could be that
  these variables may be used uninitialized.
innobase/trx/trx0rec.c:
  cleaner compiling
innobase/trx/trx0roll.c:
  cleaner compiling
innobase/trx/trx0trx.c:
  cleaner compiling
innobase/trx/trx0undo.c:
  cleaner compiling

1 files changed, 22 insertions, 22 deletions

diff --git a/innobase/que/que0que.c b/innobase/que/que0que.c
index 96e505f8b80..b43e8ea48bc 100644
--- a/innobase/que/que0que.c
+++ b/innobase/que/que0que.c
@@ -393,7 +393,7 @@ graph so that the graph can communicate an error message to the client.) */
 void
 que_fork_error_handle(
 /*==================*/
-	trx_t*	trx,	/* in: trx */
+	trx_t*	trx __attribute__((unused)),	/* in: trx */
 	que_t*	fork)	/* in: query graph which was run before signal
 			handling started, NULL not allowed */
 {
@@ -1130,47 +1130,47 @@ que_node_print_info(
 	addr = (ulint)node;
 
 	if (type == QUE_NODE_SELECT) {
-		str = "SELECT";
+		str = (char *) "SELECT";
 	} else if (type == QUE_NODE_INSERT) {
-		str = "INSERT";
+		str = (char *) "INSERT";
 	} else if (type == QUE_NODE_UPDATE) {
-		str = "UPDATE";
+		str = (char *) "UPDATE";
 	} else if (type == QUE_NODE_WHILE) {
-		str = "WHILE";
+		str = (char *) "WHILE";
 	} else if (type == QUE_NODE_ASSIGNMENT) {
-		str = "ASSIGNMENT";
+		str = (char *) "ASSIGNMENT";
 	} else if (type == QUE_NODE_IF) {
-		str = "IF";
+		str = (char *) "IF";
 	} else if (type == QUE_NODE_FETCH) {
-		str = "FETCH";
+		str = (char *) "FETCH";
 	} else if (type == QUE_NODE_OPEN) {
-		str = "OPEN";
+		str = (char *) "OPEN";
 	} else if (type == QUE_NODE_PROC) {
-		str = "STORED PROCEDURE";
+		str = (char *) "STORED PROCEDURE";
 	} else if (type == QUE_NODE_FUNC) {
-		str = "FUNCTION";
+		str = (char *) "FUNCTION";
 	} else if (type == QUE_NODE_LOCK) {
-		str = "LOCK";
+		str = (char *) "LOCK";
 	} else if (type == QUE_NODE_THR) {
-		str = "QUERY THREAD";
+		str = (char *) "QUERY THREAD";
 	} else if (type == QUE_NODE_COMMIT) {
-		str = "COMMIT";
+		str = (char *) "COMMIT";
 	} else if (type == QUE_NODE_UNDO) {
-		str = "UNDO ROW";
+		str = (char *) "UNDO ROW";
 	} else if (type == QUE_NODE_PURGE) {
-		str = "PURGE ROW";
+		str = (char *) "PURGE ROW";
 	} else if (type == QUE_NODE_ROLLBACK) {
-		str = "ROLLBACK";
+		str = (char *) "ROLLBACK";
 	} else if (type == QUE_NODE_CREATE_TABLE) {
-		str = "CREATE TABLE";
+		str = (char *) "CREATE TABLE";
 	} else if (type == QUE_NODE_CREATE_INDEX) {
-		str = "CREATE INDEX";
+		str = (char *) "CREATE INDEX";
 	} else if (type == QUE_NODE_FOR) {
-		str = "FOR LOOP";
+		str = (char *) "FOR LOOP";
 	} else if (type == QUE_NODE_RETURN) {
-		str = "RETURN";
+		str = (char *) "RETURN";
 	} else {
-		str = "UNKNOWN NODE TYPE";
+		str = (char *) "UNKNOWN NODE TYPE";
 	}
 
 	printf("Node type %lu: %s, address %lx\n", type, str, addr);