summaryrefslogtreecommitdiff
path: root/myisam/mi_dynrec.c
diff options
context:
space:
mode:
authorunknown <ingo@mysql.com>2005-04-28 15:27:42 +0200
committerunknown <ingo@mysql.com>2005-04-28 15:27:42 +0200
commit994674c09b112745fd03355a0972fbf3f4b0295c (patch)
treeacdc21ec81893c0fcc23262fdc1e7e2bf2592e0c /myisam/mi_dynrec.c
parentf63c8f53b050016c6be6a152ea01b4e17e9ee071 (diff)
downloadmariadb-git-994674c09b112745fd03355a0972fbf3f4b0295c.tar.gz
Bug#8321 - myisampack bug in compression algorithm
This is the second of three changesets. It contains the pure bug fix. It also contains the second after-review fixes. The problem was that with gcc on x86, shifts are done modulo word size. 'value' is 32 bits wide and shifting it by 32 bits is a no-op. This was triggered by an evil distribution of character incidences. A distribution of 2917027827 characters made of 202 distinct values led to 34 occurrences of 32-bit Huffman codes. This might have been the first time ever that write_bits() had to write 32-bit values. Since it can be expected that one day even 32 bits might be insufficient, the third changeset suggests to enlarge some variables to 64 bits.
Diffstat (limited to 'myisam/mi_dynrec.c')
0 files changed, 0 insertions, 0 deletions