diff options
| author | unknown <svoj@mysql.com/june.mysql.com> | 2007-07-27 14:30:25 +0500 |
|---|---|---|
| committer | unknown <svoj@mysql.com/june.mysql.com> | 2007-07-27 14:30:25 +0500 |
| commit | e011d30078454f6726ea418c2e166481bc557d88 (patch) | |
| tree | d97ff101dc6144e3fbdda72b953234618878d4b0 /myisam | |
| parent | 7319d26fa2e4dbf22d89039c13f4068fd5da0b94 (diff) | |
| download | mariadb-git-e011d30078454f6726ea418c2e166481bc557d88.tar.gz | |
BUG#29957 - alter_table.test fails
INSERT/DELETE/UPDATE followed by ALTER TABLE within LOCK TABLES
may cause table corruption on Windows.
That happens because ALTER TABLE writes outdated shared state
info into index file.
Fixed by removing obsolete workaround.
Affects MyISAM tables on Windows only.
myisam/mi_extra.c:
On windows when mi_extra(HA_EXTRA_PREPARE_FOR_DELETE) is called,
we release external lock and close index file. If we're in LOCK
TABLES, MyISAM state info doesn't get updated until UNLOCK TABLES.
That means when we release external lock and we're in LOCK TABLES,
we may write outdated state info.
As SQL layer closes all table instances, we do not need this
workaround anymore.
mysql-test/r/alter_table.result:
A test case for BUG#29957.
mysql-test/t/alter_table.test:
A test case for BUG#29957.
Diffstat (limited to 'myisam')
| -rw-r--r-- | myisam/mi_extra.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/myisam/mi_extra.c b/myisam/mi_extra.c index 5eb5010ad8c..71e65153eac 100644 --- a/myisam/mi_extra.c +++ b/myisam/mi_extra.c @@ -278,7 +278,7 @@ int mi_extra(MI_INFO *info, enum ha_extra_function function, void *extra_arg) case HA_EXTRA_PREPARE_FOR_DELETE: pthread_mutex_lock(&THR_LOCK_myisam); share->last_version= 0L; /* Impossible version */ -#ifdef __WIN__ +#ifdef __WIN__REMOVE_OBSOLETE_WORKAROUND /* Close the isam and data files as Win32 can't drop an open table */ pthread_mutex_lock(&share->intern_lock); if (flush_key_blocks(share->key_cache, share->kfile, |