diff options
| author | unknown <monty@mysql.com> | 2005-11-01 13:00:02 +0200 |
|---|---|---|
| committer | unknown <monty@mysql.com> | 2005-11-01 13:00:02 +0200 |
| commit | fffe74170576439325ae7b59bf56e55bbeeee5c4 (patch) | |
| tree | 48f465a2fa16bd4e275d38c29d8c85701e758f58 /myisam | |
| parent | cc953ed32a8cf5245aa1068bc6b7463992d2986c (diff) | |
| download | mariadb-git-fffe74170576439325ae7b59bf56e55bbeeee5c4.tar.gz | |
Review of new pushed code
Removed wrong fix for bug #14009 (use of abs() on null value causes problems with filesort)
Mark that add_time(), time_diff() and str_to_date() can return null values
myisam/mi_check.c:
keyoffset is not a position (no %lx here)
mysql-test/r/func_sapdb.result:
Fixed test after marking that timediff() can return NULL
sql/item_func.cc:
Removed wrong fix for bug #14009 (use of abs() on null value causes problems with filesort)
sql/item_timefunc.cc:
Mark that add_time and str_to_date() can return null values
sql/item_timefunc.h:
Mark that time_diff can return 0
sql/spatial.cc:
Simple cleanups during review of new code
Diffstat (limited to 'myisam')
| -rw-r--r-- | myisam/mi_check.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/myisam/mi_check.c b/myisam/mi_check.c index 8783a5fef54..15d1cceebfe 100644 --- a/myisam/mi_check.c +++ b/myisam/mi_check.c @@ -1839,7 +1839,7 @@ static int sort_one_index(MI_CHECK *param, MI_INFO *info, MI_KEYDEF *keyinfo, if (sort_one_index(param,info,keyinfo,next_page,new_file)) { DBUG_PRINT("error", - ("From page: %ld, keyoffset: 0x%lx used_length: %d", + ("From page: %ld, keyoffset: %lu used_length: %d", (ulong) pagepos, (ulong) (keypos - buff), (int) used_length)); DBUG_DUMP("buff",(byte*) buff,used_length); |