diff options
| author | timour@askmonty.org <timour@askmonty.org> | 2013-10-29 12:39:03 +0200 |
|---|---|---|
| committer | timour@askmonty.org <timour@askmonty.org> | 2013-10-29 12:39:03 +0200 |
| commit | 883af99e7dac91e3f258135a2053e6b8e3c05fc3 (patch) | |
| tree | 1881d9d2b897cfb3e086ed5a29a3a6bba6e0a410 /mysql-test/r/group_by.result | |
| parent | 94ad392fd86b53f798c7de9489afe901e1f3a9b6 (diff) | |
| download | mariadb-git-883af99e7dac91e3f258135a2053e6b8e3c05fc3.tar.gz | |
MDEV-5104 crash in Item_field::used_tables with broken order by
Analysis:
st_select_lex_unit::prepare() computes can_skip_order_by as TRUE.
As a result join->prepare() gets called with order == NULL, and
doesn't do name resolution for the inner ORDER clause. Due to this
the prepare phase doesn't detect that the query references non-exiting
function and field.
Later join->optimize() calls update_used_tables() for a non-resolved
Item_field, which understandably has no Field object. This call results
in a crash.
Solution:
Resolve unnecessary ORDER BY clauses to detect if they reference non-exising
objects. Then remove such clauses from the JOIN object.
Diffstat (limited to 'mysql-test/r/group_by.result')
| -rw-r--r-- | mysql-test/r/group_by.result | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/mysql-test/r/group_by.result b/mysql-test/r/group_by.result index 07cccf149ee..1bcec672e26 100644 --- a/mysql-test/r/group_by.result +++ b/mysql-test/r/group_by.result @@ -2407,4 +2407,9 @@ a 200 set optimizer_switch=@save_optimizer_switch; DROP TABLE t1,t2; +# +# MDEV-5104 crash in Item_field::used_tables with broken order by +# +(select 1 order by x(y)) order by 1; +ERROR 42S22: Unknown column 'y' in 'order clause' # End of 5.3 tests |