Added option --valgrind-mysqltest to mysql-test-run

Added flag to Field::store(longlong) to specify if value is unsigned.
This fixes bug #12750: Incorrect storage of 9999999999999999999 in DECIMAL(19, 0)
Fixed warning from valgrind in CREATE ... SELECT
Fixed double free of mysql.options if reconnect failed


mysql-test/mysql-test-run.sh:
  Added option --valgrind-mysqltest to allow one to run mysqltest with valgrind
mysql-test/r/bigint.result:
  Update results after fix for Field::store(longlong)
mysql-test/r/range.result:
  Update results after fix for Field::store(longlong)
mysql-test/r/strict.result:
  Update results after fix for Field::store(longlong)
  (This fixes some wrong results when storing things into bigint columns)
mysql-test/r/type_ranges.result:
  Update results after fix for Field::store(longlong)
mysql-test/t/bigint.test:
  Added testing for #12750: Incorrect storage of 9999999999999999999 in DECIMAL(19, 0)
mysql-test/t/innodb.test:
  Removed comments affected by this bug fix
mysql-test/t/mysqldump.test:
  Fixed result to not depend on existing config files
mysql-test/t/range.test:
  0xff numbers are now unsigned
mysql-test/t/strict.test:
  Added errors for things that previously (wrongly) succeeded
sql-common/client.c:
  Fixed double free of mysql.options if reconnect failed
sql/field.cc:
  Added flag to Field::store(longlong) to specify if value is unsigned
sql/field.h:
  Added flag to Field::store(longlong) to specify if value is unsigned
sql/field_conv.cc:
  Fixed calls to Field::store(longlong,flag)
sql/ha_ndbcluster.cc:
  Fixed calls to Field::store(longlong,flag)
sql/handler.cc:
  Fixed calls to Field::store(longlong,flag)
sql/item.cc:
  Fixed calls to Field::store(longlong,flag)
sql/item_sum.cc:
  Fixed calls to Field::store(longlong,flag)
sql/sp.cc:
  Fixed calls to Field::store(longlong,flag)
sql/sql_acl.cc:
  Fixed calls to Field::store(longlong,flag)
sql/sql_help.cc:
  Fixed calls to Field::store(longlong,flag)
sql/sql_show.cc:
  Fixed calls to Field::store(longlong,flag)
sql/sql_table.cc:
  Fixed varning from valgrind
sql/sql_udf.cc:
  Fixed calls to Field::store(longlong,flag)
sql/tztime.cc:
  Fixed calls to Field::store(longlong,flag)
sql/unireg.cc:
  Fixed calls to Field::store(longlong,flag)

1 files changed, 152 insertions, 1 deletions

diff --git a/mysql-test/t/bigint.test b/mysql-test/t/bigint.test
index 5f21d2b5813..d9c1abd9ba9 100644
--- a/mysql-test/t/bigint.test
+++ b/mysql-test/t/bigint.test
@@ -35,21 +35,27 @@ drop table t1;
 
 create table t1 ( a int not null default 1, big bigint );
 insert into t1 (big) values (-1),(12345678901234567),(9223372036854775807),(18446744073709551615);
+select * from t1;
 select min(big),max(big),max(big)-1 from t1;
 select min(big),max(big),max(big)-1 from t1 group by a;
 alter table t1 modify big bigint unsigned not null;
 select min(big),max(big),max(big)-1 from t1;
 select min(big),max(big),max(big)-1 from t1 group by a;
+insert into t1 (big) values (18446744073709551615);
+select * from t1;
+select min(big),max(big),max(big)-1 from t1;
+select min(big),max(big),max(big)-1 from t1 group by a;
 alter table t1 add key (big);
 select min(big),max(big),max(big)-1 from t1;
 select min(big),max(big),max(big)-1 from t1 group by a;
 alter table t1 modify big bigint not null;
+select * from t1;
 select min(big),max(big),max(big)-1 from t1;
 select min(big),max(big),max(big)-1 from t1 group by a;
 drop table t1;
 
 #
-# Test problem with big values fir auto_increment
+# Test problem with big values for auto_increment
 #
 
 create table t1 (id bigint auto_increment primary key, a int) auto_increment=9999999999;
@@ -112,6 +118,7 @@ drop table t1, t2;
 #
 # Test of CREATE ... SELECT and unsigned integers
 #
+
 create table t1 select 1 as 'a';
 show create table t1;
 drop table t1;
@@ -119,3 +126,147 @@ create table t1 select 9223372036854775809 as 'a';
 show create table t1;
 select * from t1;
 drop table t1;
+DROP DATABASE IF EXISTS `scott`;
+
+
+#
+# Check various conversions from/to unsigned bigint.
+#
+
+create table t1 (a char(100), b varchar(100), c text, d blob);
+insert into t1 values(
+  18446744073709551615,18446744073709551615,
+  18446744073709551615, 18446744073709551615
+);
+
+insert into t1 values (-1 | 0,-1 | 0,-1 | 0 ,-1 | 0);
+select * from t1;
+drop table t1;
+
+create table t1 ( quantity decimal(2) unsigned);
+insert into t1 values (500), (-500), (~0), (-1);
+select * from t1;
+drop table t1;
+
+#
+# Test of storing decimal values in BIGINT range
+# (Bug #12750: Incorrect storage of 9999999999999999999 in DECIMAL(19, 0))
+#
+
+CREATE TABLE t1 (
+  `col1` INT(1) NULL,
+  `col2` INT(2) NULL,
+  `col3` INT(3) NULL,
+  `col4` INT(4) NULL,
+  `col5` INT(5) NULL,
+  `col6` INT(6) NULL,
+  `col7` INT(7) NULL,
+  `col8` INT(8) NULL,
+  `col9` INT(9) NULL,
+  `col10` BIGINT(10) NULL,
+  `col11` BIGINT(11) NULL,
+  `col12` BIGINT(12) NULL,
+  `col13` BIGINT(13) NULL,
+  `col14` BIGINT(14) NULL,
+  `col15` BIGINT(15) NULL,
+  `col16` BIGINT(16) NULL,
+  `col17` BIGINT(17) NULL,
+  `col18` BIGINT(18) NULL,
+  `col19` DECIMAL(19, 0) NULL,
+  `col20` DECIMAL(20, 0) NULL,
+  `col21` DECIMAL(21, 0) NULL,
+  `col22` DECIMAL(22, 0) NULL,
+  `col23` DECIMAL(23, 0) NULL,
+  `col24` DECIMAL(24, 0) NULL,
+  `col25` DECIMAL(25, 0) NULL,
+  `col26` DECIMAL(26, 0) NULL,
+  `col27` DECIMAL(27, 0) NULL,
+  `col28` DECIMAL(28, 0) NULL,
+  `col29` DECIMAL(29, 0) NULL,
+  `col30` DECIMAL(30, 0) NULL,
+  `col31` DECIMAL(31, 0) NULL,
+  `col32` DECIMAL(32, 0) NULL,
+  `col33` DECIMAL(33, 0) NULL,
+  `col34` DECIMAL(34, 0) NULL,
+  `col35` DECIMAL(35, 0) NULL,
+  `col36` DECIMAL(36, 0) NULL,
+  `col37` DECIMAL(37, 0) NULL,
+  `col38` DECIMAL(38, 0) NULL,
+  `fix1` DECIMAL(38, 1) NULL,
+  `fix2` DECIMAL(38, 2) NULL,
+  `fix3` DECIMAL(38, 3) NULL,
+  `fix4` DECIMAL(38, 4) NULL,
+  `fix5` DECIMAL(38, 5) NULL,
+  `fix6` DECIMAL(38, 6) NULL,
+  `fix7` DECIMAL(38, 7) NULL,
+  `fix8` DECIMAL(38, 8) NULL,
+  `fix9` DECIMAL(38, 9) NULL,
+  `fix10` DECIMAL(38, 10) NULL,
+  `fix11` DECIMAL(38, 11) NULL,
+  `fix12` DECIMAL(38, 12) NULL,
+  `fix13` DECIMAL(38, 13) NULL,
+  `fix14` DECIMAL(38, 14) NULL,
+  `fix15` DECIMAL(38, 15) NULL,
+  `fix16` DECIMAL(38, 16) NULL,
+  `fix17` DECIMAL(38, 17) NULL,
+  `fix18` DECIMAL(38, 18) NULL,
+  `fix19` DECIMAL(38, 19) NULL,
+  `fix20` DECIMAL(38, 20) NULL,
+  `fix21` DECIMAL(38, 21) NULL,
+  `fix22` DECIMAL(38, 22) NULL,
+  `fix23` DECIMAL(38, 23) NULL,
+  `fix24` DECIMAL(38, 24) NULL,
+  `fix25` DECIMAL(38, 25) NULL,
+  `fix26` DECIMAL(38, 26) NULL,
+  `fix27` DECIMAL(38, 27) NULL,
+  `fix28` DECIMAL(38, 28) NULL,
+  `fix29` DECIMAL(38, 29) NULL,
+  `fix30` DECIMAL(38, 30) NULL
+);
+
+INSERT INTO t1(`col1`, `col2`, `col3`, `col4`, `col5`, `col6`, `col7`, `col8`, `col9`, `col10`, `col11`, `col12`, `col13`, `col14`, `col15`, `col16`, `col17`, `col18`, `col19`, `col20`, `col21`, `col22`, `col23`, `col24`, `col25`, `col26`, `col27`, `col28`, `col29`, `col30`, `col31`, `col32`, `col33`, `col34`, `col35`, `col36`, `col37`, `col38`, `fix1`, `fix2`, `fix3`, `fix4`, `fix5`, `fix6`, `fix7`, `fix8`, `fix9`, `fix10`, `fix11`, `fix12`, `fix13`, `fix14`, `fix15`, `fix16`, `fix17`, `fix18`, `fix19`, `fix20`, `fix21`, `fix22`, `fix23`, `fix24`, `fix25`, `fix26`, `fix27`, `fix28`, `fix29`, `fix30`)
+VALUES (9, 99, 999, 9999, 99999, 999999, 9999999, 99999999, 999999999,
+9999999999, 99999999999, 999999999999, 9999999999999, 99999999999999,
+999999999999999, 9999999999999999, 99999999999999999, 999999999999999999,
+9999999999999999999, 99999999999999999999, 999999999999999999999,
+9999999999999999999999, 99999999999999999999999, 999999999999999999999999,
+9999999999999999999999999, 99999999999999999999999999,
+999999999999999999999999999, 9999999999999999999999999999,
+99999999999999999999999999999, 999999999999999999999999999999,
+9999999999999999999999999999999, 99999999999999999999999999999999,
+999999999999999999999999999999999, 9999999999999999999999999999999999,
+99999999999999999999999999999999999, 999999999999999999999999999999999999,
+9999999999999999999999999999999999999, 99999999999999999999999999999999999999,
+9999999999999999999999999999999999999.9,
+999999999999999999999999999999999999.99,
+99999999999999999999999999999999999.999,
+9999999999999999999999999999999999.9999,
+999999999999999999999999999999999.99999,
+99999999999999999999999999999999.999999,
+9999999999999999999999999999999.9999999,
+999999999999999999999999999999.99999999,
+99999999999999999999999999999.999999999,
+9999999999999999999999999999.9999999999,
+999999999999999999999999999.99999999999,
+99999999999999999999999999.999999999999,
+9999999999999999999999999.9999999999999,
+999999999999999999999999.99999999999999,
+99999999999999999999999.999999999999999,
+9999999999999999999999.9999999999999999,
+999999999999999999999.99999999999999999,
+99999999999999999999.999999999999999999,
+9999999999999999999.9999999999999999999,
+999999999999999999.99999999999999999999,
+99999999999999999.999999999999999999999,
+9999999999999999.9999999999999999999999,
+999999999999999.99999999999999999999999,
+99999999999999.999999999999999999999999,
+9999999999999.9999999999999999999999999,
+999999999999.99999999999999999999999999,
+99999999999.999999999999999999999999999,
+9999999999.9999999999999999999999999999,
+999999999.99999999999999999999999999999,
+99999999.999999999999999999999999999999);
+
+SELECT * FROM t1;
+DROP TABLE t1;