diff options
| author | unknown <anozdrin/alik@alik.opbmk> | 2007-02-20 22:31:50 +0300 |
|---|---|---|
| committer | unknown <anozdrin/alik@alik.opbmk> | 2007-02-20 22:31:50 +0300 |
| commit | 4bb9efa61030c699e23791fe49f8db1961e3202c (patch) | |
| tree | 29b55f2d76a570bf007728877260658e962a7551 /mysql-test | |
| parent | a3be5294e63fbd3fbec5bfd6bf81e2249c0f2365 (diff) | |
| download | mariadb-git-4bb9efa61030c699e23791fe49f8db1961e3202c.tar.gz | |
Fix for BUG#24415: Instance manager test im_daemon_life_cycle fails randomly.
The cause of im_daemon_life_cycle.imtest random failures was the following
behaviour of some implementations of LINUX threads: let's suppose that a
process has several threads (in LINUX threads, there is a separate process for
each thread). When the main process gets killed, the parent receives SIGCHLD
before all threads (child processes) die. In other words, the parent receives
SIGCHLD, when its child is not completely dead.
In terms of IM, that means that IM-angel receives SIGCHLD when IM-main is not dead
and still holds some resources. After receiving SIGCHLD, IM-angel restarts
IM-main, but IM-main failed to initialize, because previous instance (copy) of
IM-main still holds server socket (TCP-port).
Another problem here was that IM-angel restarted IM-main only if it was killed
by signal. If it exited with error, IM-angel thought it's intended / graceful
shutdown and exited itself.
So, when the second instance of IM-main failed to initialize, IM-angel thought
it's intended shutdown and quit.
The fix is
1. to change IM-angel so that it restarts IM-main if it exited with error code;
2. to change IM-main so that it returns proper exit code in case of failure.
mysql-test/t/disabled.def:
Enable im_daemon_life_cycle.
server-tools/instance-manager/listener.cc:
Set error status if Listener failed to initialize.
server-tools/instance-manager/manager.cc:
Return exit code from the manager.
server-tools/instance-manager/manager.h:
Return exit code from the manager.
server-tools/instance-manager/mysqlmanager.cc:
1. Restart IM-main if exit code is not EXIT_SUCCESS (0).
2. Log IM-main exit code in case of failure.
server-tools/instance-manager/thread_registry.cc:
Add support for exit code.
server-tools/instance-manager/thread_registry.h:
Add support for exit code.
Diffstat (limited to 'mysql-test')
| -rw-r--r-- | mysql-test/t/disabled.def | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/mysql-test/t/disabled.def b/mysql-test/t/disabled.def index 99ba55a7e2b..eaea7c710b0 100644 --- a/mysql-test/t/disabled.def +++ b/mysql-test/t/disabled.def @@ -10,7 +10,6 @@ # ############################################################################## -im_daemon_life_cycle : Bug#24415 see note: [19 Dec 23:17] Trudy Pelzer ndb_load : Bug#17233 user_limits : Bug#23921 random failure of user_limits.test |