diff options
author | He Zhenxing <zhenxing.he@sun.com> | 2009-03-06 17:32:00 +0800 |
---|---|---|
committer | He Zhenxing <zhenxing.he@sun.com> | 2009-03-06 17:32:00 +0800 |
commit | 82fc35475c160df1cf911df3c49972c9927d4d7c (patch) | |
tree | 97641cee8ff185e623a4631361a352115743f178 /mysys/my_pread.c | |
parent | 62d5d85c5d19b113b772ecadbf32f198831b543b (diff) | |
download | mariadb-git-82fc35475c160df1cf911df3c49972c9927d4d7c.tar.gz |
BUG#22082 Slave hangs(holds mutex) on "disk full"
When disk is full, server may waiting for free space while
writing binlog, relay-log or MyISAM tables. The server will
continue after user have freed some space. But the error
message printed was not quite clear about the how often the
error message is printed, and there will be a delay before
the server continue and user freeing space. And caused users
thinking that the server was hanging forever.
This patch fixed the problem by making the error messages
printed more clear. The error message is split into two part,
the first part will only be printed once, and the second part
will be printed very 10 times.
Message first part:
Disk is full writing '<filename>' (Errcode: <errorno>). Waiting
for someone to free space... (Expect up to 60 secs delay for
server to continue after freeing disk space)
Message second part:
Retry in 60 secs, Message reprinted in 600 secs
Diffstat (limited to 'mysys/my_pread.c')
-rw-r--r-- | mysys/my_pread.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/mysys/my_pread.c b/mysys/my_pread.c index 2d42a6ebbc4..d5bb29ff6a4 100644 --- a/mysys/my_pread.c +++ b/mysys/my_pread.c @@ -121,10 +121,8 @@ uint my_pwrite(int Filedes, const byte *Buffer, uint Count, my_off_t offset, if ((my_errno == ENOSPC || my_errno == EDQUOT) && (MyFlags & MY_WAIT_IF_FULL)) { - if (!(errors++ % MY_WAIT_GIVE_USER_A_MESSAGE)) - my_error(EE_DISK_FULL,MYF(ME_BELL | ME_NOREFRESH), - my_filename(Filedes),my_errno,MY_WAIT_FOR_USER_TO_FIX_PANIC); - VOID(sleep(MY_WAIT_FOR_USER_TO_FIX_PANIC)); + wait_for_free_space(my_filename(Filedes), errors); + errors++; continue; } if ((writenbytes > 0 && (uint) writenbytes != (uint) -1) || |