summaryrefslogtreecommitdiff
path: root/sql/field_conv.cc
diff options
context:
space:
mode:
authorTor Didriksen <tor.didriksen@oracle.com>2011-07-04 13:53:07 +0200
committerTor Didriksen <tor.didriksen@oracle.com>2011-07-04 13:53:07 +0200
commit7779c79f04cb0471ef307d03baa8eac1cc37d2ed (patch)
tree87a2c93295b84f83e7b2fd5aa0b018533889f70f /sql/field_conv.cc
parentc5a294e82854138a64e37dfadd4b1a27381b145c (diff)
downloadmariadb-git-7779c79f04cb0471ef307d03baa8eac1cc37d2ed.tar.gz
Bug#11908153: CRASH AND/OR VALGRIND ERRORS IN FIELD_BLOB::GET_KEY_IMAGE
Field_geom::reset() failed to reset its base Field_blob. The range optimizer used the un-initilized field during optimization and execution. mysql-test/r/gis.result: New test case. mysql-test/t/gis.test: New test case. sql/field.h: Field_geom::reset() must call Field_blob::reset(), even if the field is not nullable.
Diffstat (limited to 'sql/field_conv.cc')
-rw-r--r--sql/field_conv.cc3
1 files changed, 3 insertions, 0 deletions
diff --git a/sql/field_conv.cc b/sql/field_conv.cc
index 3890fe395d7..1a3ac9de08b 100644
--- a/sql/field_conv.cc
+++ b/sql/field_conv.cc
@@ -178,7 +178,10 @@ set_field_to_null_with_conversions(Field *field, bool no_conversions)
((Field_timestamp*) field)->set_time();
return 0; // Ok to set time to NULL
}
+
+ // Note: we ignore any potential failure of reset() here.
field->reset();
+
if (field == field->table->next_number_field)
{
field->table->auto_increment_field_not_null= FALSE;