summaryrefslogtreecommitdiff
path: root/sql/field_conv.cc
diff options
context:
space:
mode:
authorunknown <kroki@mysql.com>2006-06-30 18:14:22 +0400
committerunknown <kroki@mysql.com>2006-06-30 18:14:22 +0400
commitfc085d77ade3e0cd77aebe1456c59b951301d722 (patch)
tree922256d4e955f855a6cc441d718ec5126b13236f /sql/field_conv.cc
parent9bbfa9fbf1e614ebeb211693d8e89043b631e20f (diff)
downloadmariadb-git-fc085d77ade3e0cd77aebe1456c59b951301d722.tar.gz
Bug#17226: Variable set in cursor on first iteration is assigned
second iterations value During assignment to the BLOB variable in routine body the value wasn't copied. mysql-test/r/sp-vars.result: Add result for bug#17226. mysql-test/t/sp-vars.test: Add test case for bug#17226. sql/field_conv.cc: Honor copy_blobs flag.
Diffstat (limited to 'sql/field_conv.cc')
-rw-r--r--sql/field_conv.cc11
1 files changed, 8 insertions, 3 deletions
diff --git a/sql/field_conv.cc b/sql/field_conv.cc
index 4e977c06180..3200f2ca9b2 100644
--- a/sql/field_conv.cc
+++ b/sql/field_conv.cc
@@ -675,9 +675,14 @@ void field_conv(Field *to,Field *from)
{ // Be sure the value is stored
Field_blob *blob=(Field_blob*) to;
from->val_str(&blob->value);
- if (!blob->value.is_alloced() &&
- from->real_type() != MYSQL_TYPE_STRING &&
- from->real_type() != MYSQL_TYPE_VARCHAR)
+ /*
+ Copy value if copy_blobs is set, or source is not a string and
+ we have a pointer to its internal string conversion buffer.
+ */
+ if (to->table->copy_blobs ||
+ (!blob->value.is_alloced() &&
+ from->real_type() != MYSQL_TYPE_STRING &&
+ from->real_type() != MYSQL_TYPE_VARCHAR))
blob->value.copy();
blob->store(blob->value.ptr(),blob->value.length(),from->charset());
return;