summaryrefslogtreecommitdiff
path: root/sql/ha_ndbcluster.cc
diff options
context:
space:
mode:
authorunknown <tomas@whalegate.ndb.mysql.com>2007-03-21 08:40:24 +0100
committerunknown <tomas@whalegate.ndb.mysql.com>2007-03-21 08:40:24 +0100
commit49f2196da044715f6584b4887d84bdd54ad9d185 (patch)
tree3514f6d00ec63adbee8dfe0df71acb70ef344cad /sql/ha_ndbcluster.cc
parent7c143080586045daaa600ae6d5c2a15af0479cfc (diff)
downloadmariadb-git-49f2196da044715f6584b4887d84bdd54ad9d185.tar.gz
Bug #26825 MySQL Server Crashes in high load
- initialize to NULL, to avoid call of free on uninitialized variable
Diffstat (limited to 'sql/ha_ndbcluster.cc')
-rw-r--r--sql/ha_ndbcluster.cc11
1 files changed, 7 insertions, 4 deletions
diff --git a/sql/ha_ndbcluster.cc b/sql/ha_ndbcluster.cc
index 3d0d8a3f079..877005039e2 100644
--- a/sql/ha_ndbcluster.cc
+++ b/sql/ha_ndbcluster.cc
@@ -952,7 +952,7 @@ int ha_ndbcluster::get_metadata(const char *path)
DBUG_PRINT("enter", ("m_tabname: %s, path: %s", m_tabname, path));
do {
- const void *data, *pack_data;
+ const void *data= NULL, *pack_data= NULL;
uint length, pack_length;
if (!(tab= dict->getTable(m_tabname)))
@@ -3755,7 +3755,7 @@ int ha_ndbcluster::external_lock(THD *thd, int lock_type)
if ((my_errno= build_index_list(ndb, table, ILBP_OPEN)))
DBUG_RETURN(my_errno);
- const void *data, *pack_data;
+ const void *data= NULL, *pack_data= NULL;
uint length, pack_length;
if (readfrm(table->s->path, &data, &length) ||
packfrm(data, length, &pack_data, &pack_length) ||
@@ -4343,7 +4343,7 @@ int ha_ndbcluster::create(const char *name,
NDBTAB tab;
NDBCOL col;
uint pack_length, length, i, pk_length= 0;
- const void *data, *pack_data;
+ const void *data= NULL, *pack_data= NULL;
char name2[FN_HEADLEN];
bool create_from_engine= (info->table_options & HA_OPTION_CREATE_FROM_ENGINE);
@@ -4378,8 +4378,11 @@ int ha_ndbcluster::create(const char *name,
if (readfrm(name, &data, &length))
DBUG_RETURN(1);
if (packfrm(data, length, &pack_data, &pack_length))
+ {
+ my_free((char*)data, MYF(0));
DBUG_RETURN(2);
-
+ }
+
DBUG_PRINT("info", ("setFrm data: 0x%lx len: %d", (long) pack_data, pack_length));
tab.setFrm(pack_data, pack_length);
my_free((char*)data, MYF(0));