diff options
| author | unknown <tomas@poseidon.mysql.com> | 2007-02-06 00:09:45 +0700 |
|---|---|---|
| committer | unknown <tomas@poseidon.mysql.com> | 2007-02-06 00:09:45 +0700 |
| commit | fa839ece5735c9656279dc0d798e92000c2a7aa9 (patch) | |
| tree | 2d7c5c05ba35fd720b9034f09c9bd2de4d392ca2 /sql/ha_ndbcluster_binlog.cc | |
| parent | dd01c46f364a06d01d2e0a78015c243c82a826f9 (diff) | |
| download | mariadb-git-fa839ece5735c9656279dc0d798e92000c2a7aa9.tar.gz | |
Bug #26021 valgrind warning handle_trailing_share/ndbcluster_free_share invalid read
- revert bugfix, needs more work
Diffstat (limited to 'sql/ha_ndbcluster_binlog.cc')
| -rw-r--r-- | sql/ha_ndbcluster_binlog.cc | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/sql/ha_ndbcluster_binlog.cc b/sql/ha_ndbcluster_binlog.cc index 5a0089e59ac..55364f31764 100644 --- a/sql/ha_ndbcluster_binlog.cc +++ b/sql/ha_ndbcluster_binlog.cc @@ -2445,8 +2445,10 @@ int ndbcluster_create_binlog_setup(Ndb *ndb, const char *key, pthread_mutex_unlock(&ndbcluster_mutex); DBUG_RETURN(1); } +#ifdef NOT_YET if (share->connect_count != g_ndb_cluster_connection->get_connect_count()) +#endif { handle_trailing_share(share); share= NULL; @@ -2454,11 +2456,14 @@ int ndbcluster_create_binlog_setup(Ndb *ndb, const char *key, } /* Create share which is needed to hold replication information */ +#ifdef NOT_YET if (share) { ++share->use_count; } - else if (!(share= get_share(key, 0, TRUE, TRUE))) + else +#endif + if (!(share= get_share(key, 0, TRUE, TRUE))) { sql_print_error("NDB Binlog: " "allocating table share for %s failed", key); |