MDEV-22283 Server crashes in key_copy or unexpected error 156

(The table already existed in the storage engine)

Wrong algorithm of closing partitions on error doesn't close last
partition.

1 files changed, 6 insertions, 4 deletions

diff --git a/sql/ha_partition.cc b/sql/ha_partition.cc
index af60ca68c82..6af69fc67b6 100644
--- a/sql/ha_partition.cc
+++ b/sql/ha_partition.cc
@@ -3657,11 +3657,13 @@ int ha_partition::open(const char *name, int mode, uint test_if_locked)
 
 err_handler:
   DEBUG_SYNC(ha_thd(), "partition_open_error");
-  file= &m_file[m_tot_parts - 1];
-  while (file-- != m_file)
+  DBUG_ASSERT(m_tot_parts > 0);
+  for (uint i= m_tot_parts - 1; ; --i)
   {
-    if (bitmap_is_set(&m_opened_partitions, (uint)(file - m_file)))
-      (*file)->ha_close();
+    if (bitmap_is_set(&m_opened_partitions, i))
+      m_file[i]->ha_close();
+    if (!i)
+      break;
   }
 err_alloc:
   free_partition_bitmaps();