BUG#17138: Crashes in stored procedure

Last round of review fixes


BUILD/compile-pentium-gcov:
  No change
sql/ha_ndbcluster.h:
  Last round of review changes
sql/ha_partition.h:
  Last round of review changes
sql/handler.h:
  Last round of review changes
sql/item_sum.cc:
  Last round of review changes
sql/sql_acl.cc:
  Last round of review changes
sql/sql_insert.cc:
  Last round of review changes
sql/sql_select.cc:
  Last round of review changes
sql/sql_table.cc:
  Last round of review changes
sql/sql_union.cc:
  Last round of review changes
sql/sql_update.cc:
  Last round of review changes

1 files changed, 2 insertions, 3 deletions

diff --git a/sql/ha_partition.h b/sql/ha_partition.h
index 4b85ddd2def..4c627cd50f8 100644
--- a/sql/ha_partition.h
+++ b/sql/ha_partition.h
@@ -304,9 +304,8 @@ public:
 
   virtual bool is_fatal_error(int error, uint flags)
   {
-    if (!handler::is_fatal_error(error, flags))
-      return FALSE;
-    if (error == HA_ERR_NO_PARTITION_FOUND)
+    if (!handler::is_fatal_error(error, flags) ||
+        error == HA_ERR_NO_PARTITION_FOUND)
       return FALSE;
     return TRUE;
   }