summaryrefslogtreecommitdiff
path: root/sql/handler.h
diff options
context:
space:
mode:
authorSergei Petrunia <psergey@askmonty.org>2016-10-30 21:07:16 +0000
committerSergei Petrunia <psergey@askmonty.org>2016-10-30 21:07:16 +0000
commit997c86c76c3a5e92f297b9740dbc9b6a65bb771d (patch)
tree203ce964331ae487bec33628cd7046db5730f379 /sql/handler.h
parent4462e77afad40f32dbb6dbcdb34eef0225a7e149 (diff)
downloadmariadb-git-997c86c76c3a5e92f297b9740dbc9b6a65bb771d.tar.gz
MariaRocks port: fix rocksdb.handler_basic test
MySQL has each storage engine to increment Handler_XXX counters, while MariaDB has handler::ha_XXX() methods to do the increments. MariaDB's solution doesn't work for storage engines that implement handler::read_range_first(), though. Make ha_rocksdb::read_range_first increment the counter (when it is calling handler::ha_XXX() function that will)
Diffstat (limited to 'sql/handler.h')
-rw-r--r--sql/handler.h8
1 files changed, 7 insertions, 1 deletions
diff --git a/sql/handler.h b/sql/handler.h
index 775d21ed3ff..dca052b0ac9 100644
--- a/sql/handler.h
+++ b/sql/handler.h
@@ -3928,10 +3928,16 @@ private:
void mark_trx_read_write_internal();
bool check_table_binlog_row_based_internal(bool binlog_row);
- /* Private helpers */
+protected:
+ /*
+ These are intended to be used only by handler::ha_xxxx() functions
+ However, engines that implement read_range_XXX() (like MariaRocks)
+ or embed other engines (like ha_partition) may need to call these also
+ */
inline void increment_statistics(ulong SSV::*offset) const;
inline void decrement_statistics(ulong SSV::*offset) const;
+private:
/*
Low-level primitives for storage engines. These should be
overridden by the storage engine class. To call these methods, use