summaryrefslogtreecommitdiff
path: root/sql/item_cmpfunc.cc
diff options
context:
space:
mode:
authorunknown <bar@bar.mysql.r18.ru>2003-07-02 18:34:43 +0500
committerunknown <bar@bar.mysql.r18.ru>2003-07-02 18:34:43 +0500
commit9f6614292b8061063e709147b1282dda84c7f018 (patch)
tree57404c7cd0076832db00a260d7b44107d5ddeb69 /sql/item_cmpfunc.cc
parent7db27aded20baf0e870b23b67225f52ec183a274 (diff)
downloadmariadb-git-9f6614292b8061063e709147b1282dda84c7f018.tar.gz
There is no Item->binary() anymore. It was remain from 4.0.
Diffstat (limited to 'sql/item_cmpfunc.cc')
-rw-r--r--sql/item_cmpfunc.cc11
1 files changed, 3 insertions, 8 deletions
diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc
index e3586fef260..a19311cd2fe 100644
--- a/sql/item_cmpfunc.cc
+++ b/sql/item_cmpfunc.cc
@@ -380,12 +380,7 @@ bool Item_in_optimizer::fix_fields(THD *thd, struct st_table_list *tables,
return 1;
if (args[0]->maybe_null)
maybe_null=1;
- /*
- TODO: Check if following is right
- (set_charset set type of result, not how compare should be used)
- */
- if (args[0]->binary())
- set_charset(&my_charset_bin);
+
with_sum_func= args[0]->with_sum_func;
used_tables_cache= args[0]->used_tables();
const_item_cache= args[0]->const_item();
@@ -933,7 +928,7 @@ Item *Item_func_case::find_item(String *str)
if ((tmp=args[i]->val_str(str))) // If not null
{
/* QQ: COERCIBILITY */
- if (first_expr_is_binary || args[i]->binary())
+ if (first_expr_is_binary || (args[i]->charset()->state & MY_CS_BINSORT))
{
if (sortcmp(tmp,first_expr_str,&my_charset_bin)==0)
return args[i+1];
@@ -1044,7 +1039,7 @@ Item_func_case::fix_fields(THD *thd, TABLE_LIST *tables, Item **ref)
used_tables_cache|=(first_expr)->used_tables();
const_item_cache&= (first_expr)->const_item();
with_sum_func= with_sum_func || (first_expr)->with_sum_func;
- first_expr_is_binary= first_expr->binary();
+ first_expr_is_binary= first_expr->charset()->state & MY_CS_BINSORT;
}
if (else_expr)
{