diff options
author | unknown <monty@mysql.com> | 2005-11-01 13:00:02 +0200 |
---|---|---|
committer | unknown <monty@mysql.com> | 2005-11-01 13:00:02 +0200 |
commit | fffe74170576439325ae7b59bf56e55bbeeee5c4 (patch) | |
tree | 48f465a2fa16bd4e275d38c29d8c85701e758f58 /sql/item_func.cc | |
parent | cc953ed32a8cf5245aa1068bc6b7463992d2986c (diff) | |
download | mariadb-git-fffe74170576439325ae7b59bf56e55bbeeee5c4.tar.gz |
Review of new pushed code
Removed wrong fix for bug #14009 (use of abs() on null value causes problems with filesort)
Mark that add_time(), time_diff() and str_to_date() can return null values
myisam/mi_check.c:
keyoffset is not a position (no %lx here)
mysql-test/r/func_sapdb.result:
Fixed test after marking that timediff() can return NULL
sql/item_func.cc:
Removed wrong fix for bug #14009 (use of abs() on null value causes problems with filesort)
sql/item_timefunc.cc:
Mark that add_time and str_to_date() can return null values
sql/item_timefunc.h:
Mark that time_diff can return 0
sql/spatial.cc:
Simple cleanups during review of new code
Diffstat (limited to 'sql/item_func.cc')
-rw-r--r-- | sql/item_func.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sql/item_func.cc b/sql/item_func.cc index aff4adb788a..df32672e12b 100644 --- a/sql/item_func.cc +++ b/sql/item_func.cc @@ -766,7 +766,6 @@ void Item_func_abs::fix_length_and_dec() hybrid_type= REAL_RESULT; if (args[0]->result_type() == INT_RESULT) hybrid_type= INT_RESULT; - maybe_null= 1; } |