diff options
| author | Sergey Vojtovich <svoj@mariadb.org> | 2019-02-13 17:40:03 +0400 |
|---|---|---|
| committer | Sergey Vojtovich <svoj@mariadb.org> | 2019-02-13 17:40:03 +0400 |
| commit | 8a3a332bc083d4900431da65e2375a1f89ad02f6 (patch) | |
| tree | 774d739193f7ed289fdea69fdc470732df049e86 /sql/item_func.cc | |
| parent | a3ccad0f21e48e30c98f91528e3fcbbf2c1d509a (diff) | |
| download | mariadb-git-8a3a332bc083d4900431da65e2375a1f89ad02f6.tar.gz | |
Cleanup Item_func_sp::fix_fields()
No need to call list.empty(): first one is called by List constructor,
second one doesn't make sense as the object is destroyed immediately
afterwards.
Diffstat (limited to 'sql/item_func.cc')
| -rw-r--r-- | sql/item_func.cc | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/sql/item_func.cc b/sql/item_func.cc index da0e669ae9d..86f00ecb412 100644 --- a/sql/item_func.cc +++ b/sql/item_func.cc @@ -6522,12 +6522,9 @@ Item_func_sp::fix_fields(THD *thd, Item **ref) if (arg_count) { List<Item> list; - list.empty(); - for (uint i=0; i < arg_count; i++) - list.push_back(*(args+i)); - + for (uint i= 0; i < arg_count; i++) + list.push_back(args[i]); item_sp= new (thd->mem_root) Item_sum_sp(thd, context, m_name, sp, list); - list.empty(); } else item_sp= new (thd->mem_root) Item_sum_sp(thd, context, m_name, sp); |